Skip to content

Fix head_to_set for custom sets #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odow merged 2 commits into from
Sep 20, 2026
+24 −1
Merged

Fix head_to_set for custom sets #3089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fe9cfc
Fix head_to_set for custom sets
blegat Sep 19, 2026
5d74685
Add test
blegat Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/FileFormats/MOF/read.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ macro head_to_val(f, arg1, args...)
push!(leaf.args, new_expr)
leaf = new_expr
end
push!(leaf.args, Expr(:return, Val(head)))
push!(leaf.args, :(return Val(Symbol($head))))
quote
function $(esc(f))($head::String)
return $body
Expand Down
23 changes: 23 additions & 0 deletions test/FileFormats/MOF/test_MOF.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1681,6 +1681,29 @@ function test_unsupported_objectives()
return
end

struct CustomSet <: MOI.AbstractVectorSet
dimension::Int
end

function MOF.set_to_moi(::Val{:CustomSet}, object::Dict)
return CustomSet(object["dimension"])
end

function test_custom_set_to_moi()
object = Dict{String,Any}("type" => "CustomSet", "dimension" => 3)
@test MOF.set_to_moi(Val(:CustomSet), Float64, object) == CustomSet(3)
@test MOF.set_to_moi(Float64, object) == CustomSet(3)
return
end

function test_head_to_val()
@test MOF.head_to_set("Nonnegatives") === Val(:Nonnegatives)
@test MOF.head_to_set("CustomSet") === Val(:CustomSet)
@test MOF.head_to_function("VectorOfVariables") === Val(:VectorOfVariables)
@test MOF.head_to_function("CustomFunction") === Val(:CustomFunction)
return
end

function test_unsupported_kwarg()
@test_throws(
ErrorException(
Expand Down
Loading