fix: propagate CryptoKeys Location field through gRPC bridge - #574
Open
Functionhx wants to merge 1 commit into
Open
fix: propagate CryptoKeys Location field through gRPC bridge#574Functionhx wants to merge 1 commit into
Functionhx wants to merge 1 commit into
Conversation
…h bridge Add missing Location field to the CryptoKeysFormat protobuf message and populate it in both gRPC bridge conversion functions (send_tr_rpc_custom_message_to_mythic_c2 and send_tr_rpc_mythic_c2_to_custom_message). This allows translator containers to distinguish between C2-profile keys and payload-build keys via gRPC. Regenerate the protobuf raw descriptor to include field 4 (Location) so it is actually serialized over the wire. Fixes its-a-feature#495 Signed-off-by: Functionhx <2994114386@qq.com>
Owner
|
Love the enthusiasm here! Normally I'd pull this in, but I'm addressing this in the next major Mythic 4.0 update (https://github.com/its-a-feature/Mythic/blob/auth-adjustments/mythic-docker/src/grpc/services/translationContainerGRPC.proto#L28) - the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Location field to CryptoKeysFormat protobuf and propagate through server bridge, Go client SDK, and Python client SDK so translation containers can distinguish callback/staging/C2/payload keys.
Related PRs:
Fixes: #495
Signed-off-by: Functionhx 2994114386@qq.com