Fix PrefixSet watch mapper in RoutingPolicy controller - #563
Merged
Merged
Conversation
felix-kaestner
force-pushed
the
fix/prefixset-watch-handler
branch
from
September 14, 2026 13:26
e164b5c to
e95d2a4
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
hardikdr
added
the
area/switch-automation
The prefixSetToRoutingPolicy mapper queried the field index using prefixSet.Spec.Name (the device-level name) but the index stores PrefixSetRef.Name (the Kubernetes object name). When these differ, the mapper silently failed to find the RoutingPolicy that references the PrefixSet, preventing re-reconciliation after a PrefixSet is created. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
felix-kaestner
force-pushed
the
fix/prefixset-watch-handler
branch
from
September 15, 2026 09:55
e95d2a4 to
7d915f8
Compare
swagner-de
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prefixSetToRoutingPolicy mapper queried the field index using prefixSet.Spec.Name (the device-level name) but the index stores PrefixSetRef.Name (the Kubernetes object name). When these differ, the mapper silently failed to find the RoutingPolicy that references the PrefixSet, preventing re-reconciliation after a PrefixSet is created.