Skip to content

[#267] Do not allow other plugins to invoke register_regexes_from_array (main) - #268

Merged
korydraughn merged 2 commits into
irods:mainfrom
korydraughn:267.m
Sep 20, 2026
Merged

[#267] Do not allow other plugins to invoke register_regexes_from_array (main)#268
korydraughn merged 2 commits into
irods:mainfrom
korydraughn:267.m

Conversation

@korydraughn

@korydraughn korydraughn commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related to irods/irods#9078.

This PR moves the mentioned function into a nearby anonymous namespace.

Will run tests soon.

@korydraughn
korydraughn force-pushed the 267.m branch 2 times, most recently from b385c9f to 83ecd23 Compare September 15, 2026 20:02
@korydraughn korydraughn mentioned this pull request Sep 15, 2026
Merged
@korydraughn korydraughn mentioned this pull request Sep 17, 2026
Merged
@korydraughn

korydraughn commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Running core tests against irods/irods#9080.

The irods/irods PR doesn't change any server functionality, so running against it is the same as testing against tip of main irods/irods.

It also means we get to run this PR against the core test suite with the new test added by the irods/irods PR.

@korydraughn

korydraughn commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

All core tests passed except the following:

  • test_all_rules.Test_AllRules
  • test_ips
  • test_resource_types.Test_Resource_ReplicationToTwoCompoundResourcesWithPreferArchive

I'm pretty sure the failures have nothing to do with this PR.

Investigating now.

MartinFlores751
MartinFlores751 reviewed Sep 17, 2026
View reviewed changes

@MartinFlores751 MartinFlores751 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Don't forget to leave a comment about your findings on the test failures.

@korydraughn korydraughn mentioned this pull request Sep 18, 2026
Closed
@korydraughn

korydraughn commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

The following test suites needed skip annotations and tweaks to support the PREP. See irods/irods@da662b2 and irods/irods@2045889.

  • test_all_rules.Test_AllRules
  • test_ips

test_resource_types.Test_Resource_ReplicationToTwoCompoundResourcesWithPreferArchive is fixed by 40a0bf4.

@korydraughn

korydraughn commented Sep 20, 2026

Copy link
Copy Markdown
Contributor Author

With the tweaks mentioned in #268 (comment), all core tests pass against irods/irods#9080.

This is ready.

@trel

trel commented Sep 20, 2026

Copy link
Copy Markdown
Member

looks good to me.

@korydraughn
[irods#267] Do not allow other plugins to invoke register_regexes_fro…
bb70388 
…m_array

This commit moves the register_regexes_from_array function into a nearby
anonymous namespace.
@korydraughn
[irods#272] Mirror NREP's clearing of the rError stack for dynamic PEPs
36c6d19
@korydraughn
korydraughn merged commit bff9f92 into irods:main Sep 20, 2026
2 checks passed
@korydraughn
korydraughn deleted the 267.m branch September 20, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@MartinFlores751 MartinFlores751 MartinFlores751 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@korydraughn @trel @MartinFlores751