fix(cli): load default exports from JavaScript config - #8593
Open
jabrailkhalil wants to merge 2 commits into
Open
jabrailkhalil wants to merge 2 commits into
jabrailkhalil wants to merge 2 commits into
Conversation
Author
|
The CI workflows for the current head |
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Sep 16, 2026
…-preferred conflicts)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
capacitor.config.jsusesexport default, Node returns a module namespace object. The CLI reads settings from that wrapper, soappIdandappNamebecome empty andwebDirfalls back towww.Unwrap the default export using the same logic as the TypeScript config loader. Add regression tests that run the built config loader in a separate Node process, covering real ES modules and existing CommonJS configurations without Jest transforming the module format.
Fixes #8267.
Validation on Windows, Node 22.21.1:
webDir: "www".git diff --checkpass.Native Android/iOS builds and the full platform integration suite were not run.