Preserve Gemma tool types and response whitespace - #228
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Referenced union schemas are still silently rendered as strings or empty parameter schemas.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Preserves Gemma schema types, structured tool-result types, and response whitespace during Llama transcript rendering.
Changes:
- Recursively resolves Gemma schema references.
- Preserves structured and mixed tool-output segment types.
- Aligns completed-response whitespace handling and expands tests.
File summaries
| File | Description |
|---|---|
Sources/AnyLanguageModel/Models/LlamaToolCallFormat.swift |
Resolves schemas and renders typed tool responses. |
Sources/AnyLanguageModel/Models/LlamaLanguageModel.swift |
Preserves output whitespace and passes typed segments. |
Tests/AnyLanguageModelTests/LlamaToolCallFormatTests.swift |
Tests nested schemas, whitespace, and typed responses. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gemma tool declarations could describe nested argument types as strings, and transcript replay converted structured arrays and scalar tool results into quoted strings. This follow-up to #227 addresses all three comments from Copilot's re-review.
Gemma now explicitly rejects unsupported
anyOf,oneOf, andallOfschemas at the root, in properties, and in array items, addressing the latest review.