Finish a response stream only after its transcript entries are committed - #224
Merged
Merged
Conversation
wrapStream reported completion before appending the response (and, since #181, the streamed tool entries) to the session transcript, so a caller that drains the stream and immediately starts the next turn could build its prompt from an incomplete transcript. Commit the entries and clear isResponding first, then finish the stream, on both the success and the error path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #181 (Copilot's one finding there, which predates that PR).
wrapStreamreported completion before appending the response, and since #181 the streamed tool entries, to the session transcript. A caller that drains the stream and immediately starts the next turn could build its prompt from an incomplete transcript. Now the entries are committed andisRespondingis cleared first, then the stream finishes, on both the success and the error path.Default suite: 340 tests pass locally.