Route think and keep_alive to the top level of Ollama chat requests - #200
Merged
Merged
Conversation
james-333i
force-pushed
the
fix/152-ollama-think
branch
from
September 2, 2026 15:56
11ff173 to
8d499d0
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The newly supported keep_alive routing lacks request-encoding coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Routes Ollama’s think and keep_alive options to /api/chat’s top-level request body while retaining other custom options under options.
Changes:
- Extracts recognized top-level parameters.
- Applies routing to streaming and non-streaming requests.
- Adds request-construction tests.
File summaries
| File | Description |
|---|---|
Sources/AnyLanguageModel/Models/OllamaLanguageModel.swift |
Implements top-level parameter routing. |
Tests/AnyLanguageModelTests/OllamaLanguageModelTests.swift |
Tests routing and reserved-key protection. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ollama's /api/chat endpoint reads think and keep_alive as top-level siblings of model and messages, so passing them through the custom options dictionary buried them inside options where the server ignores them. Route those keys to the top level of the request body and keep every other custom key in options. Reserved request keys cannot be overridden. Adds request-encoding tests that run without a live Ollama server. Fixes huggingface#152
james-333i
force-pushed
the
fix/152-ollama-think
branch
from
September 10, 2026 18:16
8d499d0 to
7e639a5
Compare
Contributor
Author
|
@mattt Rebased onto main and added a keep_alive encoding test alongside the think one. |
Collaborator
|
Thanks, @james-333i! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ollama's /api/chat endpoint reads think and keep_alive as top-level siblings of model and messages, so passing them through the custom options dictionary buried them inside options where the server ignores them.
Route those keys to the top level of the request body and keep every other custom key in options. Reserved request keys cannot be overridden. Adds request-encoding tests that run without a live Ollama server.
Fixes #152
Resubmitted after an accidental force push closed #184.