Skip to content

chore(databases): simplify fork error description - #149

Merged
hotdata-automation[bot] merged 1 commit into
mainfrom
openapi-update-35823100089
Sep 23, 2026
Merged

hotdata-automation[bot] merged 1 commit into
mainfrom
openapi-update-35823100089

Conversation

@hotdata-automation

Copy link
Copy Markdown
Contributor

Auto-generated from the updated HotData OpenAPI spec.
Source: https://github.com/hotdata-dev/www/pull/431

@hotdata-automation
hotdata-automation Bot requested a review from a team as a code owner September 23, 2026 05:36
@hotdata-automation
hotdata-automation Bot requested review from shefeek-jinnah and removed request for a team September 23, 2026 05:36
@hotdata-automation
hotdata-automation Bot enabled auto-merge (squash) September 23, 2026 05:36
Comment thread CHANGELOG.md

### Changed

- chore(databases): simplify fork error description

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: record the source-breaking model changes under [Unreleased] (not blocking).

This regen renames key_determines to constant_per_key on AddManagedTableDecl, AddManagedTableRequest, and DatabaseDefaultTableDecl. The regen also adds a required constant_per_key field to TableInfo, which changes the arity of TableInfo::new. Both changes break downstream compilation on upgrade.

CHANGELOG.md line 6 states the crate follows Semantic Versioning, and the 0.17.0 section marks this kind of change with Breaking:. The seeded bullet names only the fork error description, so a release author reading [Unreleased] sees no reason to pick minor over patch. Add a bullet naming the rename and the TableInfo field.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated client matches the spec change. One non-blocking changelog nit inline.

@hotdata-automation
hotdata-automation Bot merged commit d6ec175 into main Sep 23, 2026
4 checks passed
@hotdata-automation
hotdata-automation Bot deleted the openapi-update-35823100089 branch September 23, 2026 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants