chore(databases): simplify fork error description - #149
Merged
Merged
Conversation
hotdata-automation
Bot
requested review from
shefeek-jinnah
and removed request for
a team
September 23, 2026 05:36
|
|
||
| ### Changed | ||
|
|
||
| - chore(databases): simplify fork error description |
Contributor
There was a problem hiding this comment.
nit: record the source-breaking model changes under [Unreleased] (not blocking).
This regen renames key_determines to constant_per_key on AddManagedTableDecl, AddManagedTableRequest, and DatabaseDefaultTableDecl. The regen also adds a required constant_per_key field to TableInfo, which changes the arity of TableInfo::new. Both changes break downstream compilation on upgrade.
CHANGELOG.md line 6 states the crate follows Semantic Versioning, and the 0.17.0 section marks this kind of change with Breaking:. The seeded bullet names only the fork error description, so a release author reading [Unreleased] sees no reason to pick minor over patch. Add a bullet naming the rename and the TableInfo field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated from the updated HotData OpenAPI spec.
Source: https://github.com/hotdata-dev/www/pull/431