Conversation
Bortlesboat
left a comment
There was a problem hiding this comment.
Checked 89205665b1a70cea061c43705ffb44b234655ab1 on native Windows with Node 24.14.0 and Bun 1.3.14. All 61 focused tests pass: 55 across previewLifecycle.test.ts and openBrowser.test.ts, plus six in telemetry/client.test.ts. Oxlint and oxfmt also pass for all six changed files.
For a fresh checkout, the telemetry suite needs the parser/lint packages and core's generated runtime modules first. After building @hyperframes/parsers, @hyperframes/lint, and @hyperframes/core, it collects and passes without source edits. The initial missing-module errors were checkout preparation, not failures of this patch.
I checked all three modified spawn paths: the added option retains their detached behavior, stdio routing, and existing unref() calls, and the preview injection type includes the new option. No issue found within this change.
This supplies Windows test/build evidence, but the focused tests mock process spawning. Actual visible console behavior when launching a real preview or browser remains unverified; I did not repeat the full monorepo suite.
|
Closing — stale draft PR. Please reopen if still relevant. |
Summary
windowsHide: trueto telemetry exit flush, custom browser launch, and background preview detached spawnsFixes #3476
Verification
bun run --filter @hyperframes/cli test -- src/telemetry/client.test.ts src/utils/openBrowser.test.ts src/commands/previewLifecycle.test.ts(61 passed)bun run --filter @hyperframes/cli typecheckbun run lintbun run format:checkbun run buildgit diff --checkwindowsHidefromopenBrowsermade its new regression test failThe full
bun run testis not clean in this environment. Studio has 97 failures caused primarily by unavailablelocalStorage, and the full CLI run has 3 unrelatedskillsManifest.test.tslock-pruning failures. The focused tests for all changed paths pass.Windows real-device validation has not been performed.
Scope
This does not change ffmpeg handling from #3379 or chrome-headless-shell handling from #3430. It does not add a shared spawn helper or lint rule.
AI assistance
Implemented and verified with Hermes Agent using Codex. I reviewed the resulting diff and test evidence.