Windows: link manifest records Vulkan import lib as vulkan, breaking non-CMake consumers (LNK1181) - #103
Merged
Conversation
cmake/transcribe-install.cmake records `vulkan` into transcribe-link.json's system_libs on every OS, but Windows' LunarG SDK ships the import lib as `vulkan-1.lib`. A consumer that reconstructs the link line from the manifest (the Rust -sys crate, the link_smoke C consumer) then asks MSVC for a nonexistent `vulkan.lib` and dies with LNK1181: cannot open input file 'vulkan.lib'. The in-tree ggml-vulkan target links fine because it uses find_package(Vulkan) -> Vulkan::Vulkan (an absolute path); only the hand-written manifest reconstruction hardcodes the Unix basename. Emit `vulkan-1` under if(WIN32) and `vulkan` otherwise, matching how whisper-rs-sys resolves the same import lib. Non-Windows output is byte identical.
Contributor
|
Thanks. I'll try to take a look at this and pull it in soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmake/transcribe-install.cmakewritesvulkanintotranscribe-link.json'ssystem_libson every OS, but Windows' LunarG SDK ships the import lib asvulkan-1.lib— so a consumer reconstructing the link line from the manifest (the Rust-syscrate, thelink_smokeC consumer) asks MSVC for a nonexistentvulkan.liband dies withLNK1181: cannot open input file 'vulkan.lib'.The in-tree ggml-vulkan target links fine because it uses
find_package(Vulkan)→Vulkan::Vulkan(an absolute path); only the hand-written manifest reconstruction hardcodes the Unix basename.Fix: emit
vulkan-1underif(WIN32)andvulkanotherwise, matching how whisper-rs-sys resolves the same import lib. Non-Windows output is byte-identical.