[Bugfix] Fix corrupted remote attribute reads with chained mbufs - #1186
Open
lowbaud wants to merge 1 commit into
Open
[Bugfix] Fix corrupted remote attribute reads with chained mbufs#1186lowbaud wants to merge 1 commit into
lowbaud wants to merge 1 commit into
Conversation
Walk the mbuf chain instead of copying the full packet length from the first buffer.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes characteristic reads when the response is split across multiple mbufs.
I ran into this with MTU 512 while reading a larger characteristic. The data was correct up to byte 279 and corrupted after that. This likely won’t show up with smaller MTUs where the response fits into a single mbuf.
From what I can tell, the issue is that the full packet length is copied from the first mbuf's data pointer instead of walking the mbuf chain. I don't work with NimBLE internals regularly, so please double-check that assumption.
This changes the read handling so chained mbufs are copied correctly instead of being treated as one contiguous buffer.
I targeted release/2.5 since that’s where I reproduced the issue and wanted to keep the change minimal. Happy to retarget this to master if that’s preferred.