Skip to content

feat: [Bigtable] Publish AvroSchema to CBT admin API - #9601

Closed
gcf-owl-bot[bot] wants to merge 8 commits into
mainfrom
owl-bot-copy-Bigtable
Closed

gcf-owl-bot[bot] wants to merge 8 commits into
mainfrom
owl-bot-copy-Bigtable

Conversation

@gcf-owl-bot

@gcf-owl-bot gcf-owl-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor
  • Regenerate this pull request now.

docs: Modify ProtoSchema description
docs: Add AvroSchema description

PiperOrigin-RevId: 974526241

Source-Link: googleapis/googleapis@2295794

Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ae7092b73e329ae92be1987404eae19a5b7bf92
Copy-Tag: eyJwIjoiQmlndGFibGUvLk93bEJvdC55YW1sIiwiaCI6IjRhZTcwOTJiNzNlMzI5YWU5MmJlMTk4NzQwNGVhZTE5YTViN2JmOTIifQ==

BEGIN_NESTED_COMMIT
chore: [Bigtable] configure grpc service config for PHP Bigtable
PiperOrigin-RevId: 972068784

Source-Link: googleapis/googleapis@1182557

Source-Link: https://github.com/googleapis/googleapis-gen/commit/44cbd81232e3b93b394628be36ac3520ce6baaee
Copy-Tag: eyJwIjoiQmlndGFibGUvLk93bEJvdC55YW1sIiwiaCI6IjQ0Y2JkODEyMzJlM2I5M2IzOTQ2MjhiZTM2YWMzNTIwY2U2YmFhZWUifQ==
END_NESTED_COMMIT

PiperOrigin-RevId: 972068784

Source-Link: googleapis/googleapis@1182557

Source-Link: googleapis/googleapis-gen@44cbd81
Copy-Tag: eyJwIjoiQmlndGFibGUvLk93bEJvdC55YW1sIiwiaCI6IjQ0Y2JkODEyMzJlM2I5M2IzOTQ2MjhiZTM2YWMzNTIwY2U2YmFhZWUifQ==
@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 27, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 27, 2026
@gcf-owl-bot
gcf-owl-bot Bot marked this pull request as ready for review August 27, 2026 21:01
@gcf-owl-bot
gcf-owl-bot Bot requested review from a team as code owners August 27, 2026 21:01
@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 27, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 27, 2026
@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2026
@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2026
@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2026
@JoeWang1127

JoeWang1127 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

The Bigtable conformance test TestMutateRow_Generic_DeadlineExceeded failed after introducing the gRPC service configuration. With the new retry policy, MutateRow now treats DEADLINE_EXCEEDED as retryable.

During the test, a 2-second perOperationTimeout is configured against a mock server with a 10-second sleep. Previously, the test proxy only passed timeoutMillis without specifying retrySettings.totalTimeoutMillis.

When the initial 2-second call timed out with DEADLINE_EXCEEDED, GAX fell back to the default 60-second total timeout and initiated a retry. The Go mock server in cloud-bigtable-clients-test was only configured for a single request, causing a nil pointer dereference panic when the unexpected retry request arrived.

Fix this by setting retrySettings.totalTimeoutMillis in ProxyService::MutateRow, aligning it with other retryable methods (ReadRow, ReadRows, BulkMutateRows) so that GAX respects the total per-operation deadline and ceases retrying once the timeout is reached.

@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2026
@bshaffer bshaffer added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 31, 2026
@bshaffer

Copy link
Copy Markdown
Contributor

Adding "Do Not Merge" label until we hear back from Bigtable that these changes are safe

docs: Modify ProtoSchema description
docs: Add AvroSchema description

PiperOrigin-RevId: 974526241

Source-Link: googleapis/googleapis@2295794

Source-Link: googleapis/googleapis-gen@4ae7092
Copy-Tag: eyJwIjoiQmlndGFibGUvLk93bEJvdC55YW1sIiwiaCI6IjRhZTcwOTJiNzNlMzI5YWU5MmJlMTk4NzQwNGVhZTE5YTViN2JmOTIifQ==
@gcf-owl-bot gcf-owl-bot Bot changed the title chore: [Bigtable] configure grpc service config for PHP Bigtable feat: [Bigtable] Publish AvroSchema to CBT admin API Sep 1, 2026
@snippet-bot

snippet-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 1, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 1, 2026
@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 1, 2026
@gcf-owl-bot

gcf-owl-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Owl bot is regenerating pull request 9601...
Build name: Y2M1NDVjMjgtY2E5Ny00N2JjLWI5YjAtYTY4ZWM1YjBlMGY4

@JoeWang1127

Copy link
Copy Markdown
Contributor

@bshaffer Can we close this pull request? Librarian manages library updates now.

@bshaffer

bshaffer commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

@JoeWang1127 no problem at all... I was just hoping to use it to test my changes for the failing comnformance tests before closing it

@JoeWang1127
JoeWang1127 deleted the owl-bot-copy-Bigtable branch September 11, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing. owl-bot-copy owlbot:run Add this label to trigger the Owlbot post processor.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants