Skip to content

Update smol-toml to 1.7.1 - #244

Closed
abdulahmad307 with Copilot wants to merge 1 commit into
mainfrom
copilot/update-smol-toml-1-7-1
Closed

abdulahmad307 with Copilot wants to merge 1 commit into
mainfrom
copilot/update-smol-toml-1-7-1

Conversation

Copilot AI commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Updates the transitive smol-toml resolution to 1.7.1 to address the reported security vulnerability.

  • Dependency resolution
    • Adds an npm override for smol-toml@1.7.1.
    • Updates package-lock.json so installs resolve the patched version.
"overrides": {
  "postcss": "8.5.23",
  "smol-toml": "1.7.1"
}

Co-authored-by: abdulahmad307 <204748719+abdulahmad307@users.noreply.github.com>
@abdulahmad307
abdulahmad307 marked this pull request as ready for review September 18, 2026 14:14
@abdulahmad307
abdulahmad307 requested a review from a team as a code owner September 18, 2026 14:14
@abdulahmad307
abdulahmad307 requested review from v-joelamyman and a balanced review from Copilot September 18, 2026 14:14
@abdulahmad307

Copy link
Copy Markdown
Contributor

@abdulahmad307

Copy link
Copy Markdown
Contributor

@copilot is the override necessary? or is the update in package-lock.json enough?

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The override and lockfile consistently resolve the vulnerable dependency to the patched release.

Pull request overview

Updates the transitive smol-toml dependency to the patched version addressing its denial-of-service vulnerability.

Changes:

  • Adds an npm override for smol-toml@1.7.1.
  • Updates the lockfile resolution and integrity metadata.
File summaries
File Description
package.json Forces the patched transitive dependency version.
package-lock.json Locks smol-toml to version 1.7.1.
Review details
  • Files reviewed: 1/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

@copilot is the override necessary? or is the update in package-lock.json enough?

The override is necessary. markdownlint-cli2 pins its own dependency to the exact version "smol-toml": "1.7.0". I tested removing the override and regenerating the lockfile: npm still resolves the top-level smol-toml correctly, but it also creates a nested node_modules/markdownlint-cli2/node_modules/smol-toml pinned at the vulnerable 1.7.0, since that's the exact version markdownlint-cli2's own manifest requires. The override forces all resolutions (including that nested one) to 1.7.1, so it's required to fully close the vulnerability.

@JoyceZhu

Copy link
Copy Markdown
Contributor

@abdulahmad307 looks like the low-priority vulnerability patch isn't due til January, and the override won't be necessary once the release mentioned DavidAnson/markdownlint-cli2#936 happens upstream; wonder if we should just wait and see if that can fix it.

@abdulahmad307

Copy link
Copy Markdown
Contributor

@abdulahmad307 looks like the low-priority vulnerability patch isn't due til January, and the override won't be necessary once the release mentioned DavidAnson/markdownlint-cli2#936 happens upstream; wonder if we should just wait and see if that can fix it.

I can close for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants