Pin GitHub Actions to commit SHAs - #3259
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The local build-ui composite action still contains two mutable external action references.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Pins direct workflow action dependencies to immutable SHAs and adds a Dependabot update cooldown.
Changes:
- Pins 34 workflow action references with version comments.
- Adds a seven-day GitHub Actions cooldown.
File summaries
| File | Description |
|---|---|
.github/workflows/registry-releaser.yml |
Pins checkout and Go setup. |
.github/workflows/moderator.yml |
Pins checkout and moderation actions. |
.github/workflows/mcp-diff.yml |
Pins checkout and Go setup. |
.github/workflows/lint.yml |
Pins lint workflow actions. |
.github/workflows/license-check.yml |
Pins license-check actions. |
.github/workflows/goreleaser.yml |
Pins release and attestation actions. |
.github/workflows/go.yml |
Pins build workflow actions. |
.github/workflows/docs-check.yml |
Pins documentation-check actions. |
.github/workflows/docker-publish.yml |
Pins checkout and cache actions. |
.github/workflows/code-scanning.yml |
Pins CodeQL and setup actions. |
.github/workflows/close-inactive-issues.yml |
Pins the stale action. |
.github/workflows/ai-issue-assessment.yml |
Pins checkout. |
.github/dependabot.yml |
Adds a seven-day cooldown. |
Review details
- Files reviewed: 13/13 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - name: Build UI | ||
| uses: ./.github/actions/build-ui | ||
| - uses: actions/setup-go@v7 | ||
| - uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 |
Staff AppSec (Actions SHA pinning)Verdict: Approve with a small follow-up (conversation comment — formal review UI often disabled here.) Pinning 34 workflow Please follow up (or amend): Otherwise LGTM from AppSec. |
Pins GitHub Actions
uses:references ingithub/github-mcp-serverto immutable commit SHAs.Summary
Why
Pinning actions to full commit SHAs prevents future tag or branch retargeting from changing workflow behavior without review.
Reviewer notes
Pinned refs
.github/workflows/ai-issue-assessment.yml:17actions/checkout@v7actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1tag.github/workflows/close-inactive-issues.yml:17actions/stale@v11actions/stale@4391f3da665fdf50b6810c1a66712fb9ba21aa93tag.github/workflows/code-scanning.yml:44actions/checkout@v7actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1tag.github/workflows/code-scanning.yml:47github/codeql-action/init@v4.37.9github/codeql-action/init@cdf488f595d80d6e07e03d4674febd5ab45fa938tag.github/workflows/code-scanning.yml:64github/codeql-action/start-proxy@v4.37.9github/codeql-action/start-proxy@cdf488f595d80d6e07e03d4674febd5ab45fa938tag.github/workflows/code-scanning.yml:70github/codeql-action/resolve-environment@v4.37.9github/codeql-action/resolve-environment@cdf488f595d80d6e07e03d4674febd5ab45fa938tag.github/workflows/code-scanning.yml:75actions/setup-go@v7actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303etag.github/workflows/code-scanning.yml:83actions/setup-node@v7actions/setup-node@820762786026740c76f36085b0efc47a31fe5020tag.github/workflows/code-scanning.yml:94github/codeql-action/autobuild@v4.37.9github/codeql-action/autobuild@cdf488f595d80d6e07e03d4674febd5ab45fa938tag.github/workflows/code-scanning.yml:97github/codeql-action/analyze@v4.37.9github/codeql-action/analyze@cdf488f595d80d6e07e03d4674febd5ab45fa938tag.github/workflows/docker-publish.yml:43actions/checkout@v7actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1tag.github/workflows/docker-publish.yml:90actions/cache@v6actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9tag.github/workflows/docs-check.yml:17actions/checkout@v7actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1tag.github/workflows/docs-check.yml:23actions/setup-go@v7actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303etag.github/workflows/go.yml:26actions/checkout@v7actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1tag.github/workflows/go.yml:32actions/setup-go@v7actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303etag.github/workflows/goreleaser.yml:17actions/checkout@v7actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1tag.github/workflows/goreleaser.yml:23actions/setup-go@v7actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303etag.github/workflows/goreleaser.yml:45actions/attest-build-provenance@v4actions/attest-build-provenance@4d101475d8b20a2381f78447822ac1eab6504dd8tag.github/workflows/license-check.yml:27actions/checkout@v7actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1tag.github/workflows/license-check.yml:39actions/setup-go@v7actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303etag.github/workflows/license-check.yml:73actions/github-script@v9actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3tag.github/workflows/license-check.yml:91actions/github-script@v9actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3tag.github/workflows/lint.yml:16actions/checkout@v7actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1tag.github/workflows/lint.yml:19actions/setup-go@v7actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303etag.github/workflows/lint.yml:23golangci/golangci-lint-action@v9golangci/golangci-lint-action@ba0d7d2ec06a0ea1cb5fa41b2e4a3ab91d21278atag.github/workflows/mcp-diff.yml:18actions/checkout@v7actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1tag.github/workflows/mcp-diff.yml:23actions/setup-go@v7actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303etag.github/workflows/mcp-diff.yml:88actions/checkout@v7actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1tag.github/workflows/mcp-diff.yml:93actions/setup-go@v7actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303etag.github/workflows/moderator.yml:19actions/checkout@v7actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1tag.github/workflows/moderator.yml:20github/ai-moderator@v1github/ai-moderator@81159c370785e295c97461ade67d7c33576e9319tag.github/workflows/registry-releaser.yml:17actions/checkout@v7actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1tag.github/workflows/registry-releaser.yml:20actions/setup-go@v7actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303etagDependabot
cooldown: default-days: 7) to the existinggithub-actionsDependabot configuration.Generated by pinner 0.1.0.