Print full PR URLs when OSC 8 hyperlinks are unsupported - #479
Open
skarim wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds plain PR URL fallbacks when OSC 8 hyperlinks are unsupported.
Changes:
- Detects terminal hyperlink support with an environment override.
- Updates PR formatting and tests.
- Documents hyperlink behavior.
Show a summary per file
| File | Description |
|---|---|
README.md |
Documents fallback behavior. |
internal/config/config.go |
Adds detection and URL formatting. |
internal/config/hyperlink_test.go |
Tests detection and formatting. |
cmd/view_test.go |
Tests short-view fallback. |
docs/src/content/docs/reference/cli.md |
Documents CLI behavior and environment variable. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prints out full PR URLs on terminals that don't support OSC 8 hyperlinks.
Supported terminals keep the existing hyperlink behavior with printing PR references. When detected terminal doesn't support, fall back to printing the full URL (
#N (full URL)). This coversgh stack view --shortand existing non-TUI status output. TUI and JSON output behavior remains unchanged.Detection is conservative for tmux, screen, Apple Terminal, Konsole, non-TTY output, and unknown terminals.
A
GH_STACK_HYPERLINKSenv var is available to override the detection —1forces hyperlinks and0forces full URLs.