Skip to content

Reuse cached GitHub organization members when building role groups #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hosom wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Reuse cached GitHub organization members when building role groups #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/entitlements/backend/github_org/provider.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ def role_name(role_identifier)
# Returns an Entitlements::Models::Group object.
Contract String => Entitlements::Models::Group
def role_to_group(role)
members = github.org_members.keys.select { |username| github.org_members[username] == role }
org_members = github.org_members
members = org_members.select { |_, member_role| member_role == role }.keys
Entitlements::Models::Group.new(
dn: role_dn(role),
members: Set.new(members),
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/entitlements/backend/github_org/provider_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

it "pulls the role name from the distinguished name" do
allow(subject).to receive(:github).and_return(github)
allow(github).to receive(:org_members).and_return(members_and_roles)
expect(github).to receive(:org_members).once.and_return(members_and_roles)
result = subject.read("member")
expect(result).to be_a_kind_of(Entitlements::Models::Group)
expect(result.member_strings).to eq(member_strings_set)
Expand Down
Loading