Support experimental model picker categories - #2394
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds Rust compatibility for experimental supplemental model categories while retaining raw RPC access and fallback handling.
Changes:
- Generates an
Experimentalmodel-picker category. - Tests supplemental model decoding, unknown categories, and
-32601errors.
Show a summary per file
| File | Description |
|---|---|
scripts/codegen/rust.ts |
Extends the Rust schema before generation. |
rust/src/generated/api_types.rs |
Adds the generated enum variant. |
rust/tests/session_test.rs |
Verifies raw RPC compatibility behavior. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/3 changed files
- Comments generated: 0
- Review effort level: Balanced
|
Companion implementation: github/copilot-agent-runtime#16936 and github/github-app#13436. This PR intentionally adds category compatibility only; the supplemental RPC remains private and is invoked through generic Client::call. |
|
Thanks for tackling the Rust side of this and for the clear test coverage on the raw Since Marking this as draft and adding |
Summary
Compatibility
This adds no first-class supplemental RPC API. Older runtimes continue returning JSON-RPC -32601, and unknown future categories still decode as Unknown.
Testing