Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The summaries match the referenced API signatures and are comprehensively validated within the stated scope.
Pull request overview
Adds C++ taint summaries for BDE Base64 and hexadecimal pointer-buffer conversions.
Changes:
- Models both
convertoverloads across four BDE converter classes. - Adds positive, negative, inheritance, and overload coverage.
- Documents the new analysis support.
File summaries
| File | Description |
|---|---|
cpp/ql/lib/ext/bdlde.model.yml |
Defines conversion summaries. |
cpp/ql/lib/change-notes/2026-09-14-bdlde-conversion-models.md |
Adds the change note. |
cpp/ql/test/library-tests/dataflow/bdlde/bdlde.h |
Declares test API fixtures. |
cpp/ql/test/library-tests/dataflow/bdlde/test.cpp |
Exercises modeled behavior. |
cpp/ql/test/library-tests/dataflow/bdlde/flow.ql |
Configures taint-flow testing. |
cpp/ql/test/library-tests/dataflow/bdlde/flow.expected |
Records expected test output. |
cpp/ql/test/library-tests/dataflow/external-models/validatemodels.expected |
Updates model-validation expectations. |
Review details
- Files reviewed: 6/7 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds taint summaries for both convert overloads of BDE bdlde
Base64Encoder,Base64Decoder,HexEncoder, andHexDecoder, propagating input bytes to the output buffer. The models match the member templates by signature and use subtypes: false, so hiding methods in derived classes do not inherit the summary.API evidence: BDE bdlde headers at ec310b87e008199ecbdbc00a0b0264a53d806a0a under Apache 2.0.
Scope is limited to direct pointer-buffer conversion; stateful flows and endConvert are left for follow-up work.
Validation covers all four classes, overloads, const/mutable inputs, inheritance/hiding behavior, and external-model validation.