Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The cleanup is internally consistent, preserves required environment handling, and includes appropriate validation.
Review tier: Balanced
Findings: None
What changed in this PR
Removes obsolete Rust toolchain overrides now that toolchain pinning is managed independently.
Changes:
- Removes fixed-toolchain selection, logging, and preinstallation.
- Uses standard
cargowhile preserving configured environment variables. - Removes the direct
ra_ap_toolchaindependency and regenerates Bazel metadata.
| File | Description |
|---|---|
rust/ql/test/setup.sh |
Stops preinstalling Rust 1.97. |
rust/ql/integration-tests/conftest.py |
Removes integration-test toolchain installation. |
rust/extractor/src/toolchain.rs |
Deletes fixed-toolchain logic. |
rust/extractor/src/qltest.rs |
Runs standard cargo with configured environment. |
rust/extractor/src/main.rs |
Removes toolchain logging and module registration. |
rust/extractor/src/config.rs |
Stops overriding RUSTUP_TOOLCHAIN. |
rust/extractor/Cargo.toml |
Removes the direct toolchain dependency. |
MODULE.bazel |
Removes the obsolete direct Bazel repository import. |
misc/bazel/3rdparty/tree_sitter_extractors_deps/ra_ap_toolchain/BUILD.bazel |
Deletes obsolete generated alias. |
misc/bazel/3rdparty/tree_sitter_extractors_deps/ra_ap_toolchain-0.0.347/BUILD.bazel |
Deletes versioned generated alias. |
misc/bazel/3rdparty/tree_sitter_extractors_deps/crates.bzl |
Regenerates direct dependency metadata. |
misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.bazel |
Removes top-level toolchain aliases. |
Cargo.lock |
Removes the extractor’s direct dependency entry. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
paldepind
marked this pull request as draft
September 14, 2026 12:16
paldepind
changed the title
paldepind
marked this pull request as ready for review
September 14, 2026 12:46
paldepind
marked this pull request as draft
September 14, 2026 12:57
Drop the synthetic format-family macro expansion path and its dedicated legacy-toolchain tests now that extraction uses a pinned compatible Rust toolchain. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
paldepind
force-pushed
the
paldepind-remove-rust-toolchain-workarounds
branch
from
September 14, 2026 13:34
c51a5eb to
2241a07
Compare
paldepind
marked this pull request as ready for review
September 14, 2026 13:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With #22493 we now pin a fixed Rust toolchain during extraction. This makes the backwards-compatibility path introduced during #22493 for projects using Rust toolchains older than 1.94 unnecessary.
This PR:
Note to reviewers: The PR essentially just reverts 7faf81f. It's not an exact revert, since some later commits tweaked things a bit.