object-file: use size_t for object size in check_object_signature() - #6415
Merged
dscho merged 1 commit intoSep 17, 2026
Merged
Conversation
Signed-off-by: David PRUDHOMME <david7.prudhomme@gmail.com>
This was referenced Sep 17, 2026
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Sep 17, 2026
…6415) `check_object_signature()` function prototype defines `size` parameter as an `unsigned long`. However, it receives `size` as `size_t` from its current callers and forwards it unchanged to `hash_object_file()`, which expects `size_t`. Using `size_t` here keeps the types consistent and avoids an implicit narrowing conversion to `unsigned long`, which may truncate values when `size >= 2^32` on Windows (an `unsigned long` is 32-bit while a `size_t` is 64-bit).
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Sep 17, 2026
…6415) `check_object_signature()` function prototype defines `size` parameter as an `unsigned long`. However, it receives `size` as `size_t` from its current callers and forwards it unchanged to `hash_object_file()`, which expects `size_t`. Using `size_t` here keeps the types consistent and avoids an implicit narrowing conversion to `unsigned long`, which may truncate values when `size >= 2^32` on Windows (an `unsigned long` is 32-bit while a `size_t` is 64-bit).
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Sep 17, 2026
…6415) `check_object_signature()` function prototype defines `size` parameter as an `unsigned long`. However, it receives `size` as `size_t` from its current callers and forwards it unchanged to `hash_object_file()`, which expects `size_t`. Using `size_t` here keeps the types consistent and avoids an implicit narrowing conversion to `unsigned long`, which may truncate values when `size >= 2^32` on Windows (an `unsigned long` is 32-bit while a `size_t` is 64-bit).
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Sep 18, 2026
…6415) `check_object_signature()` function prototype defines `size` parameter as an `unsigned long`. However, it receives `size` as `size_t` from its current callers and forwards it unchanged to `hash_object_file()`, which expects `size_t`. Using `size_t` here keeps the types consistent and avoids an implicit narrowing conversion to `unsigned long`, which may truncate values when `size >= 2^32` on Windows (an `unsigned long` is 32-bit while a `size_t` is 64-bit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_object_signature()function prototype definessizeparameter as anunsigned long. However, it receivessizeassize_tfrom its current callers and forwards it unchanged tohash_object_file(), which expectssize_t. Usingsize_there keeps the types consistent and avoids an implicit narrowing conversion tounsigned long, which may truncate values whensize >= 2^32on Windows (anunsigned longis 32-bit while asize_tis 64-bit).