fix(wasm): Forward compile options and patch frames of all exception values - #23660
Open
andreiborza wants to merge 1 commit into
Open
fix(wasm): Forward compile options and patch frames of all exception values#23660andreiborza wants to merge 1 commit into
andreiborza wants to merge 1 commit into
Conversation
Contributor
size-limit report 📦
|
andreiborza
marked this pull request as ready for review
August 27, 2026 11:49
andreiborza
requested review from
JPeer264,
isaacs and
msonnb
and removed request for
isaacs
August 27, 2026 11:49
…values Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/wasm-patch-plumbing
branch
from
August 27, 2026 12:19
d3b088d to
15efa7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The WebAssembly streaming wrappers now forward every argument they receive, so compile options (for example
builtins: ['js-string']) reach the engine. Wasm frames get patched on all exception values of an event, not only up to the first one that matches a registered image. The worker path shares the same patching code as the main thread instead of duplicating it.Why
The wrappers silently dropped the third argument, which disabled js-string builtins for anyone using the streaming APIs. Chained exceptions kept unsymbolicated frames because the short-circuit stopped further patching.