feat: Emit low-cardinality span names for messaging spans (amqplib, kafka, ...) - #23652
Open
s1gr1d wants to merge 1 commit into
Open
feat: Emit low-cardinality span names for messaging spans (amqplib, kafka, ...)#23652s1gr1d wants to merge 1 commit into
s1gr1d wants to merge 1 commit into
Conversation
s1gr1d
requested review from
JPeer264,
chargome,
isaacs and
nicohrubec
and removed request for
a team
August 26, 2026 12:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some notes on the changes:
extractQueueNamenow returnsundefinedinstead of'unknown'to better distinguish between an actual missing value vs. a string that carries a meaning that it probably shouldn't. The placeholder"unknown"moved to the place where we actually set it.The amqplib consumer names its streamed span after the exchange rather than the
queueargument, becausequeuefalls back to the high-cardinality routing key (order.created.12345) whenever thedispatchchannel fires beforeconsumeresolves.A bug fix: An SQS command with no
QueueUrlwas namedundefined receive, and now falls back to the genericSQS.ReceiveMessage.Closes #23528