fix(slack): treat steering stop as hard stop - #1845
Draft
sentry-junior[bot] wants to merge 2 commits into
Draft
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: David Cramer <david@sentry.io>
|
3 screenshot changes — 3 changed · 0 added · 0 removed Review screenshots in Frameshift
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Slack stop path only recognized bare
stopbefore the!!steering marker was removed. As a result, the exact<@junior>!! stopform entered normal steering and let the active Turn continue.This change normalizes the steering marker before stop detection, sends the command through the durable Conversation stop mechanism, and records the stop as an instruction-authority agent history item so it appears in the agent log. Resource-watch cleanup and thread unsubscribe remain follow-on effects.
Observed in: https://sentry.slack.com/archives/C0B595QDZLL/p1789107040317489
via David Cramer.
--
View Junior Session [Sentry]