build(deps): AGP 9.4.1 + Gradle 9.6 (spike — blocked on Dokka) - #80
Draft
pandeymangg wants to merge 1 commit into
Draft
pandeymangg wants to merge 1 commit into
pandeymangg wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Ref ENG-3341
What & why
Was: #77 bumps
agp8.9.2 → 9.4.1 and nothing else, so it cannot configure at all — AGP 9 needs Gradle ≥ 9.6.0 and the wrapper is on 8.11.1. That is why its CI is red.Now: wrapper bumped alongside it, plus the two build-script changes AGP 9 forces.
:android:assembleReleasepasses. Publishing does not.AGP 9 matters for security: it drops gRPC outright, which takes the entire Netty chain — 41 of the 52 open Dependabot alerts — off the plugin classpath. It does not cover everything, so it does not replace #79 (see below).
The three blockers
android.defaults.buildfeatures.buildconfigremoved in AGP 9gradle.properties;BuildConfigis referenced nowhere inandroid/srckapt(used for data binding)android.builtInKotlin=false+android.newDsl=false, Google's documented opt-out. Real fix is kapt → KSPBlocker 3 in full:
dokkaJavadocJaris part ofpublishAndReleaseToMavenCentral, so the SDK cannot be released while this stands. Dokka 2.2.0 is the latest stable — only 2.3.0-Beta is newer, and a beta doc toolchain is not something to ship on a security bump.Verified
:android:assembleReleasebuildEnvironmentio.nettyand noio.grpcon the classpath at all; protobuf3.25.5, commons-compress1.27.1:android:dokkaJavadocJarThis does not replace #79
Resolved on this branch, against what the alerts require:
Six alerts survive AGP 9, three of them high severity. #79's floors are what clear those, and they stay useful here — the Netty and protobuf halves simply go inert, which is what a floor is supposed to do.
Left to do
testDebugUnitTestonly;testReleaseUnitTestis gone, andjacocoAndroidTestReport(what SonarCloud runs) is untested here