fix: use source lists for extraction on Windows - #109
Merged
Merged
Conversation
longlho
marked this pull request as ready for review
September 18, 2026 20:38
longlho
pushed a commit
that referenced
this pull request
Sep 18, 2026
🤖 I have created a release *beep* *boop* --- ## 0.12.3 (2026-09-18) ## What's Changed * fix: use source lists for extraction on Windows by @longlho in #109 * chore(deps): update dependency oxfmt to ^0.67.0 by @renovate[bot] in #107 * chore(deps): update pnpm to v12.4.1 by @renovate[bot] in #108 **Full Changelog**: v0.12.2...v0.12.3 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large extraction targets exceed Windows' 32,767-character process command-line limit before the FormatJS CLI can start. Pass source paths through the CLI's newline-delimited
--in-fileinput instead of positional arguments.Add a regression with 512 generated source paths containing spaces and compare the extracted catalog with the existing fixture. Run it in the Windows CI job as well as the regular test suite. On native Windows Server 2025, the regression fails before this change with
command is longer than CreateProcessW's limit (32767 characters)and passes afterward.