Reverify unchanged GitRepository on key rotation - #2166
Open
matheuscscp wants to merge 1 commit into
Open
matheuscscp wants to merge 1 commit into
matheuscscp wants to merge 1 commit into
Conversation
The optimized same-revision checkout returns a partial commit and, when the content config and verification mode are unchanged, returns before verifySignature. Since the verification policy was not part of the decision, rotating spec.verify.secretRef or its key material kept an existing SourceVerified=True condition for the new generation, allowing a revoked signing key to remain trusted for the advertised artifact. Record a fingerprint of the verification public keys in the status on success, and require a full checkout and re-verification when the fingerprint of the keys in the referenced Secret changes. The fingerprint depends only on the key material, not on the Secret name or the data key names. Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com> Assisted-by: opencode/deepseek-v4.1-flash
matheuscscp
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2165
The optimized same-revision checkout skipped signature verification when only the verification Secret or its key material changed, since the change predicate tracked the verification mode but not the trusted keys. This kept a stale SourceVerified=True after a key rotation or revocation.
Record a fingerprint of the verification public keys in status on success, and require a full checkout and re-verification when that fingerprint changes. The fingerprint depends only on key material, not the Secret name or data key names.