Skip to content

Ensure false return from uncompressToBuffer is bubbled up (Snappy lib) - #2623

Merged
norberttech merged 1 commit into
flow-php:1.xfrom
asgrim:snappy-bubble-up-false-return
Sep 12, 2026
Merged

Ensure false return from uncompressToBuffer is bubbled up (Snappy lib)#2623
norberttech merged 1 commit into
flow-php:1.xfrom
asgrim:snappy-bubble-up-false-return

Conversation

@asgrim

@asgrim asgrim commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Resolves: #xxx

Change Log


Added

Fixed

  • Ensure false return from uncompressToBuffer is bubbled up, not silently ignored (e.g. on malformed input)

Changed

Removed

Deprecated

Security

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.28%. Comparing base (4c66ad6) to head (a90fca6).
⚠️ Report is 1 commits behind head on 1.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                1.x    #2623   +/-   ##
=========================================
  Coverage     84.28%   84.28%           
- Complexity    29778    29779    +1     
=========================================
  Files          1982     1982           
  Lines         86338    86339    +1     
=========================================
+ Hits          72768    72771    +3     
+ Misses        13570    13568    -2     
Components Coverage Δ
etl 91.27% <ø> (ø)
cli 75.45% <ø> (ø)
lib-array-dot 81.44% <ø> (ø)
lib-azure-sdk 64.44% <ø> (ø)
lib-doctrine-dbal-bulk 70.36% <ø> (ø)
lib-filesystem 76.07% <ø> (ø)
lib-types 90.48% <ø> (ø)
lib-parquet 70.53% <ø> (ø)
lib-parquet-viewer 82.26% <ø> (ø)
lib-snappy 89.86% <100.00%> (+0.04%) ⬆️
lib-dremel 0.00% <ø> (ø)
lib-postgresql 85.26% <ø> (+<0.01%) ⬆️
lib-telemetry 86.62% <ø> (ø)
bridge-filesystem-async-aws 86.19% <ø> (ø)
bridge-filesystem-azure 80.96% <ø> (ø)
bridge-monolog-http 91.54% <ø> (ø)
bridge-monolog-telemetry 94.79% <ø> (ø)
bridge-openapi-specification 60.86% <ø> (ø)
symfony-http-foundation 56.86% <ø> (ø)
bridge-psr18-telemetry 100.00% <ø> (ø)
bridge-psr3-telemetry 98.95% <ø> (ø)
bridge-psr7-telemetry 100.00% <ø> (ø)
bridge-telemetry-otlp 90.11% <ø> (ø)
bridge-symfony-http-foundation-telemetry 92.85% <ø> (ø)
bridge-symfony-filesystem-bundle 91.85% <ø> (ø)
bridge-symfony-filesystem-cache 98.18% <ø> (ø)
bridge-symfony-postgresql-bundle 93.04% <ø> (ø)
bridge-symfony-postgresql-cache 94.41% <ø> (ø)
bridge-symfony-postgresql-messenger 98.80% <ø> (ø)
bridge-symfony-postgresql-session 93.65% <ø> (ø)
bridge-symfony-telemetry-bundle 90.72% <ø> (ø)
adapter-chartjs 80.50% <ø> (ø)
adapter-csv 95.97% <ø> (ø)
adapter-doctrine 93.62% <ø> (ø)
adapter-google-sheet 80.11% <ø> (ø)
adapter-http 76.52% <ø> (ø)
adapter-json 65.62% <ø> (ø)
adapter-logger 28.57% <ø> (ø)
adapter-parquet 74.47% <ø> (ø)
adapter-text 70.78% <ø> (ø)
adapter-xml 59.83% <ø> (ø)
adapter-avro 0.00% <ø> (ø)
adapter-excel 78.77% <ø> (ø)
adapter-postgresql 78.03% <ø> (ø)
adapter-seal 65.69% <ø> (ø)
bridge-phpunit-postgresql 75.30% <ø> (ø)
bridge-phpunit-telemetry 87.36% <ø> (ø)
bridge-phpstan-types 0.00% <ø> (ø)
bridge-postgresql-valinor 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@norberttech
norberttech merged commit 706e98a into flow-php:1.x Sep 12, 2026
51 of 52 checks passed
@norberttech

Copy link
Copy Markdown
Member

Thanks!
It will get released on Monday under 0.44.0 tag

@norberttech norberttech added this to the 0.44.0 milestone Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants