Skip to content

Auto-update dependencies. - #2841

Merged
thatfiredev merged 1 commit into
masterfrom
dpebot-repositorygardener
Sep 10, 2026
Merged

Auto-update dependencies.#2841
thatfiredev merged 1 commit into
masterfrom
dpebot-repositorygardener

Conversation

@dpebot

@dpebot dpebot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Brought to you by your friendly Repository Gardener.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependency versions across multiple Gradle build files and the central Version Catalog, including version bumps for Compose BOM, Navigation, and Firebase BOM. The reviewer recommends referencing the Firebase BOM via the Version Catalog (using libs.firebase.bom) instead of hardcoding the version strings in individual build.gradle.kts files, which would centralize dependency management and simplify future updates.


// Import the Firebase BoM (see: https://firebase.google.com/docs/android/learn-more#bom)
implementation(platform("com.google.firebase:firebase-bom:34.18.0"))
implementation(platform("com.google.firebase:firebase-bom:34.19.0"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since firebase-bom is already defined in the Version Catalog (gradle/libs.versions.toml), we should reference it via libs.firebase.bom instead of hardcoding the version here. This centralizes dependency management and simplifies future updates.

    implementation(platform(libs.firebase.bom))


// Import the Firebase BoM (see: https://firebase.google.com/docs/android/learn-more#bom)
implementation(platform("com.google.firebase:firebase-bom:34.18.0"))
implementation(platform("com.google.firebase:firebase-bom:34.19.0"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since firebase-bom is already defined in the Version Catalog (gradle/libs.versions.toml), we should reference it via libs.firebase.bom instead of hardcoding the version here. This centralizes dependency management and simplifies future updates.

    implementation(platform(libs.firebase.bom))


// Import the Firebase BoM (see: https://firebase.google.com/docs/android/learn-more#bom)
implementation(platform("com.google.firebase:firebase-bom:34.18.0"))
implementation(platform("com.google.firebase:firebase-bom:34.19.0"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since firebase-bom is already defined in the Version Catalog (gradle/libs.versions.toml), we should reference it via libs.firebase.bom instead of hardcoding the version here. This centralizes dependency management and simplifies future updates.

    implementation(platform(libs.firebase.bom))

Comment thread auth/app/build.gradle.kts

// Import the Firebase BoM (see: https://firebase.google.com/docs/android/learn-more#bom)
implementation(platform("com.google.firebase:firebase-bom:34.18.0"))
implementation(platform("com.google.firebase:firebase-bom:34.19.0"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since firebase-bom is already defined in the Version Catalog (gradle/libs.versions.toml), we should reference it via libs.firebase.bom instead of hardcoding the version here. This centralizes dependency management and simplifies future updates.

    implementation(platform(libs.firebase.bom))


// Import the Firebase BoM (see: https://firebase.google.com/docs/android/learn-more#bom)
implementation(platform("com.google.firebase:firebase-bom:34.18.0"))
implementation(platform("com.google.firebase:firebase-bom:34.19.0"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since firebase-bom is already defined in the Version Catalog (gradle/libs.versions.toml), we should reference it via libs.firebase.bom instead of hardcoding the version here. This centralizes dependency management and simplifies future updates.

    implementation(platform(libs.firebase.bom))


// Import the Firebase BoM (see: https://firebase.google.com/docs/android/learn-more#bom)
implementation(platform("com.google.firebase:firebase-bom:34.18.0"))
implementation(platform("com.google.firebase:firebase-bom:34.19.0"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since firebase-bom is already defined in the Version Catalog (gradle/libs.versions.toml), we should reference it via libs.firebase.bom instead of hardcoding the version here. This centralizes dependency management and simplifies future updates.

    implementation(platform(libs.firebase.bom))


// Import the Firebase BoM (see: https://firebase.google.com/docs/android/learn-more#bom)
implementation(platform("com.google.firebase:firebase-bom:34.18.0"))
implementation(platform("com.google.firebase:firebase-bom:34.19.0"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since firebase-bom is already defined in the Version Catalog (gradle/libs.versions.toml), we should reference it via libs.firebase.bom instead of hardcoding the version here. This centralizes dependency management and simplifies future updates.

    implementation(platform(libs.firebase.bom))


// Import the Firebase BoM (see: https://firebase.google.com/docs/android/learn-more#bom)
implementation(platform("com.google.firebase:firebase-bom:34.18.0"))
implementation(platform("com.google.firebase:firebase-bom:34.19.0"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since firebase-bom is already defined in the Version Catalog (gradle/libs.versions.toml), we should reference it via libs.firebase.bom instead of hardcoding the version here. This centralizes dependency management and simplifies future updates.

    implementation(platform(libs.firebase.bom))

Comment thread perf/app/build.gradle.kts

// Import the Firebase BoM (see: https://firebase.google.com/docs/android/learn-more#bom)
implementation(platform("com.google.firebase:firebase-bom:34.18.0"))
implementation(platform("com.google.firebase:firebase-bom:34.19.0"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since firebase-bom is already defined in the Version Catalog (gradle/libs.versions.toml), we should reference it via libs.firebase.bom instead of hardcoding the version here. This centralizes dependency management and simplifies future updates.

    implementation(platform(libs.firebase.bom))


// Import the Firebase BoM (see: https://firebase.google.com/docs/android/learn-more#bom)
implementation(platform("com.google.firebase:firebase-bom:34.18.0"))
implementation(platform("com.google.firebase:firebase-bom:34.19.0"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since firebase-bom is already defined in the Version Catalog (gradle/libs.versions.toml), we should reference it via libs.firebase.bom instead of hardcoding the version here. This centralizes dependency management and simplifies future updates.

    implementation(platform(libs.firebase.bom))

@thatfiredev
thatfiredev merged commit 53ce11e into master Sep 10, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants