fix(manager): close authorization gaps in document move, phpinfo and sysinfo - #2459
Open
elcreator wants to merge 1 commit into
Open
fix(manager): close authorization gaps in document move, phpinfo and sysinfo#2459elcreator wants to merge 1 commit into
elcreator wants to merge 1 commit into
Conversation
…sysinfo The move form (a=51) checks the per-document ACL, but the move action (a=52) it submits to only checked the global save_document right and the new parent, so anyone holding save_document could reparent a document outside their groups by requesting a=52 directly. Both entry points now share one checkDocumentPermission() helper. phpinfo (a=200) and the system info page (a=53) reveal the server environment and the database host/name/prefix; they were open to the `logs` right, which editors commonly hold. They now require `settings`, and the sidebar link moved under the same gate. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136CYHW4NXMDFA8gfuNCx7R
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The move form (a=51) checks the per-document ACL, but the move action (a=52) it submits to only checked the global save_document right and the new parent, so anyone holding save_document could reparent a document outside their groups by requesting a=52 directly. Both entry points now share one checkDocumentPermission() helper.
phpinfo (a=200) and the system info page (a=53) reveal the server environment and the database host/name/prefix; they were open to the
logsright, which editors commonly hold. They now requiresettings, and the sidebar link moved under the same gate.