Void runner: Fix level broken after void retreating - #2918
Merged
Merged
Conversation
In 851ef55 the fade-out of the Void retreating was replaced by a dissolve shader. That was done before by uncover_all(). But that function was also responsible for clearing all tiles, and fading-in all the consumed props. Fix this regression by calling uncover_all() again, and leaving the fade-out of the Void as optional. Call it without the await so both transitions (props fade-in and Void dissolve) happen in parallel. Fix #2917
wjt
reviewed
Sep 17, 2026
|
Play this branch at https://play.threadbare.game/branches/endlessm/fix-void-runner-transition/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
…omponents/tile_map_cover.gd Co-authored-by: Will Thompson <wjt@endlessaccess.org>
wjt
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 851ef55 the fade-out of the Void retreating was replaced by a dissolve shader. That was done before by uncover_all(). But that function was also responsible for clearing all tiles, and fading-in all the consumed props.
Fix this regression by calling uncover_all() again, and leaving the fade-out of the Void as optional. Call it without the await so both transitions (props fade-in and Void dissolve) happen in parallel.
Fix #2917