Skip to content

Two new head variants for townies - #2884

Merged
manuq merged 1 commit into
endlessm:mainfrom
Nilu501:main
Sep 14, 2026
Merged

manuq merged 1 commit into
endlessm:mainfrom
Nilu501:main

Conversation

@Nilu501

@Nilu501 Nilu501 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Added two new head variants for townies, including their sprites and SpriteFrames. The new heads were added to RandomTextureSpriteBehavior so they can be selected by the character randomizer together with the existing variants.
Resolves #2294

townie-idle-head_006 townie-idle-head_007
townie.tscn.-.Threadbare.-.Godot.Engine.mp4

@Nilu501
Nilu501 requested a review from a team as a code owner September 11, 2026 19:30
@Nilu501 Nilu501 changed the title Dos nuevas variantes de cabeza para los townies Dos nuevas variantes de cabeza para los townies #2294 Sep 11, 2026
@manuq manuq mentioned this pull request Sep 11, 2026

@manuq manuq left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! I created a new repository again to avoid modifying anything I shouldn't. I'm attaching a video showing the two head variants. #2294

Thanks. You don't have to create a new pull request. In fact it would be better to continue in a single one so we maintain a conversation. Don't worry for this time. Next time, try to append commits to the existing one. Contact a mentor if you need help!

The change is perfect. The only thing missing is to update the PR title and description. Please see our contributing guidelines. In summary:

  • The title is great, but it needs to be in English, please edit it.
  • The description should explain the changes.
  • I see you referenced the ticket number in the description, nice! The only caveat is that it should be in a separate line at the end. The last line in the description should be "Resolves #2294"

@github-actions

github-actions Bot commented Sep 12, 2026

Copy link
Copy Markdown

Test build no longer available.

@Nilu501 Nilu501 changed the title Dos nuevas variantes de cabeza para los townies #2294 Two new head variants for townies Sep 12, 2026
@Nilu501

Nilu501 commented Sep 12, 2026

Copy link
Copy Markdown
Contributor Author

¡Hola! He creado un nuevo repositorio para evitar modificar nada que no deba. Adjunto un vídeo que muestra las dos variantes de la cabeza. #2294

Gracias. No es necesario crear una nueva solicitud de extracción. De hecho, sería mejor continuar con una sola para mantener la conversación. No te preocupes por esta vez. La próxima vez, intenta agregar confirmaciones a la existente. ¡Contacta a un mentor si necesitas ayuda!

El cambio es perfecto. Lo único que falta es actualizar el título y la descripción de la solicitud de extracción. Consulta nuestras directrices para colaboradores . En resumen:

  • El título es genial, pero necesita estar en inglés, por favor edítalo.
  • La descripción debe explicar los cambios.
  • Veo que has incluido el número de ticket en la descripción, ¡genial! La única salvedad es que debería ir en una línea aparte al final. La última línea de la descripción debería ser "Resuelve el ticket n.º 2294 ".

Hello! I updated the title and description. I think everything should be ready now.

@wjt
wjt requested a review from manuq September 14, 2026 09:10
@manuq
manuq merged commit 49f5fe0 into endlessm:main Sep 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add another head shape to character randomizer

2 participants