Checkpoint: Add tile change persistence - #2877
Open
NataliaOspinal wants to merge 7 commits into
Open
NataliaOspinal wants to merge 7 commits into
NataliaOspinal wants to merge 7 commits into
Conversation
|
Play this branch at https://play.threadbare.game/branches/NataliaOspinal/main/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
wjt
requested changes
Sep 14, 2026
|
|
||
| # Store everything including position, paths, and consumed tiles in a single dictionary | ||
| # bound strictly to each enemy to prevent synchronization issues. | ||
| static var saved_enemy_states: Dictionary = {} |
Member
There was a problem hiding this comment.
As commented on #1208 (comment) I don't think static variables are an appropriate approach.
Gotta fuse the new code with the og checkpoint in a way that doesn't affect (?) existing ones
Collaborator
|
@NataliaOspinal I see you have added new changes. Let us know when it's ready for review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever an enemy changes part of the tilemap as the VoidSpreadingEnemy does, if the player reaches a checkpoint and dies, the scene resets to its original state instead of keeping the changes that we'd like to keep in previous traveled zones for storytelling or possible gameplay mechanics.
To fix this, I created a new Checkpoint child class (I wasn't sure I could edit the original, but if that's the idea I could just add a checkbox for persistent enemies and the respective exports to incorporate the code to the original) that effectively tracks with both _process and _physics_process for accuracy of tile changes, checking the respective paths and its enemy states.
Note: I've included (as part of the code) a way to track the changes of a possible void-spreading guard, since that was the idea shown in the screenshots of the issue!
Resolves: #1208