Skip to content

Enemy: Play Mothsache attack sound effect on player detection - #2802

Merged
manuq merged 3 commits into
endlessm:mainfrom
Brandon-code96:main
Sep 14, 2026
Merged

Enemy: Play Mothsache attack sound effect on player detection#2802
manuq merged 3 commits into
endlessm:mainfrom
Brandon-code96:main

Conversation

@Brandon-code96

@Brandon-code96 Brandon-code96 commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Enemy: Play Mothsache attack sound effect on player detection

The Mothsache enemy now plays an attack sound effect when entering the attacking state upon detecting the player.

  • Added an AudioStreamPlayer node and linked the attack sound stream to the Mothsache component.
  • Implemented corresponding setter functions in the GDScript logic to safely handle audio stream assignments.

Resolves #1020

@Brandon-code96
Brandon-code96 requested review from a team as code owners August 28, 2026 02:57
manuq
manuq requested changes Aug 28, 2026
View reviewed changes

@manuq manuq left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of unwanted changes in this pull request. Please start by cleaning up.

For the pull request description, please follow our contributing guidelines.

Comment thread scenes/game_elements/characters/components/sprite_frames/storyweaver_purple.tres Outdated
@wjt wjt changed the title play Mothsache attack sound effect on player detection #1020 Play Mothsache attack sound effect on player detection Sep 9, 2026
@Brandon-code96 Brandon-code96 changed the title Play Mothsache attack sound effect on player detection Enemy: Play Mothsache attack sound effect on player detection Sep 9, 2026
@github-actions

github-actions Bot commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Test build no longer available.

manuq
manuq requested changes Sep 10, 2026
View reviewed changes

@manuq manuq left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't realize that this was ready for review again. Next time click "Request" or leave us a comment to let us know.

This is not for this pull request, but testing it I realize that the WAV file (from a previous contributor) has a noise in this part, that I think is unwanted:

Image

Please check the comment on using the AudioStreamPlayer2D node and the WAV folder location. The rest looks good, except there are trailing-whitespace errors. Check https://github.com/endlessm/threadbare/actions/runs/34403586388/job/102863419384 and if you want them automatically fixed, you can install pre-commit as explained here https://github.com/endlessm/threadbare/wiki/Contributing#coding-style

Comment thread scenes/game_elements/characters/enemies/mothsache/Mothsache.tscn Outdated
Comment thread scenes/game_elements/characters/enemies/mothsache/mothsache.gd Outdated
Comment thread assets/third_party/sounds/characters/enemies/guard/AttackSound.wav Outdated
@wjt
wjt removed the request for review from a team September 14, 2026 13:11
manuq
manuq approved these changes Sep 14, 2026
View reviewed changes
Comment thread scenes/game_elements/characters/enemies/mothsache/mothsache.gd Outdated
@manuq
manuq merged commit 26b6366 into endlessm:main Sep 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuq manuq manuq approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Play Mothsache sound effect when the attack animation triggers

2 participants

@Brandon-code96 @manuq