Add design doc for using git subtree to manage external libraries - #27593
Merged
Merged
Conversation
sbc100
force-pushed
the
add_subtree_design_doc
branch
from
August 22, 2026 04:48
2014a37 to
6888a75
Compare
sbc100
force-pushed
the
add_subtree_design_doc
branch
from
September 4, 2026 18:26
6888a75 to
ff1598e
Compare
sbc100
changed the title
Covers external libraries in `system/lib/` as candidates for `git subtree`, recommending `mimalloc` as the initial pilot and primary example, followed by `musl` and LLVM runtime libraries. This was done successfully in wasi-libc: WebAssembly/wasi-libc#797 See: emscripten-core#27515
sbc100
force-pushed
the
add_subtree_design_doc
branch
from
September 4, 2026 18:35
ff1598e to
ef126a5
Compare
kripken
reviewed
Sep 4, 2026
| | **`llvm-libc`** | `system/lib/llvm-libc` | [llvm/llvm-project](https://github.com/llvm/llvm-project) | Fork + `update_llvm_libc.py` | **Medium Priority**. Same monorepo considerations as `compiler-rt`. | | ||
| | **`openmp`** | `system/lib/openmp` | [llvm/llvm-project](https://github.com/llvm/llvm-project) | Fork + `update_openmp.py` | **Medium Priority**. Same monorepo considerations as `compiler-rt`. | | ||
| | **`dlmalloc`** | `system/lib/dlmalloc.c` | Doug Lea (v2.8.6) | Vendored single file | **Low Priority / Skip**. Upstream is inactive; heavily customized for Emscripten. | | ||
| | **`stb_image`** | `system/lib/stb_image.c` | [nothings/stb](https://github.com/nothings/stb) | Vendored single file | **Low Priority**. Low update frequency; single file. | |
Collaborator
Author
There was a problem hiding this comment.
Yes, although we don't current have any of those in-tree, to update.
We could potentially bring them in-tree I guess?
kripken
approved these changes
Sep 4, 2026
Collaborator
|
Nice! One thing to watch out for is squash-merging these PRs when they set up the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers external libraries in
system/lib/as candidates forgit subtree, recommendingmimallocas the initial pilot andprimary example, followed by
musland LLVM runtime libraries.This was done successfully in wasi-libc:
WebAssembly/wasi-libc#797
See: #27515