Fix float round/2, floor/2, ceil/2 raises wrong exception for invalid precision - #15872
Merged
josevalim merged 1 commit intoSep 8, 2026
Merged
Conversation
Member
|
Instead of changing this here, let's add guards around the precision in the callers to this function. |
Contributor
Author
|
All of them were already using guards. if remove the fallback clause, the error changes from ArgumentError to FunctionClauseError. Did I understand you correctly? ...
@precision_range 0..15
...
def round(float, precision) when is_float(float) and precision in @precision_range do
round(float, precision, :half_up)
end
def round(float, precision) when is_float(float) do
raise ArgumentError, invalid_precision_message(precision)
end |
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Float.round/2,Float.floor/2,Float.ceil/2raises wrong exception for invalid precisionexpected:
I did not add tests because similar tests for other methods were recently removed during "warnings when running tests" cleanup.