Fix InputStreamMonitor.writeNext() wait() not in loop - #2882
Open
robstryker wants to merge 1 commit into
Open
Conversation
Contributor
Use while loop instead of if to guard Object.wait() against spurious wakeups per JLS 17.2.1. Also check !fClosed to avoid waiting on a closed stream. Fixes eclipse-platform#2881 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if (fQueue.isEmpty())towhile (fQueue.isEmpty() && !fClosed)aroundfLock.wait()inwriteNext()to guard against spurious wakeups per JLS 17.2.1!fClosedto avoid waiting on a closed streamThe existing
ifguard was added for bug 550834 but doesn't protect against spurious wakeups. Found via SpotBugs static analysis (WA_NOT_IN_LOOP).Fixes #2881
Test plan
InputStreamMonitorTestspass🤖 Generated with Claude Code