Skip to content

Add a job family for LastSaveReferenceProvider.ReadJob - #4286

Merged
trancexpress merged 1 commit into
eclipse-platform:masterfrom
trancexpress:LastSaveReferenceProvider_job_family
Sep 2, 2026
Merged

trancexpress merged 1 commit into
eclipse-platform:masterfrom
trancexpress:LastSaveReferenceProvider_job_family

Conversation

@trancexpress

Copy link
Copy Markdown
Contributor

Tests that change file buffers of editors must wait on jobs that also do changes in parallel. LastSaveReferenceProvider.ReadJob is one such job, this change adds a job family which tests can wait on.

See: eclipse-jdt/eclipse.jdt.ui#1445

@trancexpress
trancexpress force-pushed the LastSaveReferenceProvider_job_family branch from a13331e to 18cf4e2 Compare August 27, 2026 07:40
@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Test Results

   858 files  ±0     858 suites  ±0   1h 4m 59s ⏱️ + 10m 22s
 8 216 tests ±0   7 972 ✅  - 1  243 💤 ±0  1 ❌ +1 
20 553 runs  ±0  19 882 ✅  - 1  670 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 122914b. ± Comparison against base commit b671c1d.

♻️ This comment has been updated with latest results.

@trancexpress
trancexpress force-pushed the LastSaveReferenceProvider_job_family branch from 18cf4e2 to b3117e5 Compare August 30, 2026 09:02
@eclipse-platform-bot

eclipse-platform-bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 86cf81b5952cfc810fba9c4183bfd66752d2439e Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Mon, 31 Aug 2026 07:02:53 +0000
Subject: [PATCH] Version bump(s) for 4.42 stream


diff --git a/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
index 8cdb3e3954..b55671b7dc 100644
--- a/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.editors; singleton:=true
-Bundle-Version: 3.22.100.qualifier
+Bundle-Version: 3.22.200.qualifier
 Bundle-Activator: org.eclipse.ui.internal.editors.text.EditorsPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.55.0

Further information are available in Common Build Issues - Missing version increments.

@trancexpress
trancexpress force-pushed the LastSaveReferenceProvider_job_family branch 4 times, most recently from e13f700 to 7b7c235 Compare August 31, 2026 09:45
Tests that change file buffers of editors must wait on jobs that also do changes in parallel.
LastSaveReferenceProvider.ReadJob is one such job, this change adds a job family which tests can wait on.

See: eclipse-jdt/eclipse.jdt.ui#1445
@trancexpress
trancexpress force-pushed the LastSaveReferenceProvider_job_family branch from 7b7c235 to 122914b Compare September 2, 2026 18:07
@trancexpress

Copy link
Copy Markdown
Contributor Author

1 failure in the Windows tests:

Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.548 s <<< FAILURE! -- in org.eclipse.search.tests.filesearch.ResultUpdaterTest
org.eclipse.search.tests.AllSearchTests.testRemoveProject -- Time elapsed: 0.250 s
org.eclipse.search.tests.AllSearchTests.testRemoveFile -- Time elapsed: 0.293 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <823> but was: <887>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:145)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:531)
	at org.eclipse.search.tests.filesearch.ResultUpdaterTest.testRemoveFile(ResultUpdaterTest.java:64)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

@trancexpress
trancexpress merged commit d098f1c into eclipse-platform:master Sep 2, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants