Skip to content

RO Crate 1.3 - #10

Merged
OliverWoolland merged 20 commits into
mainfrom
ro-crate-1.3
Sep 21, 2026
Merged

OliverWoolland merged 20 commits into
mainfrom
ro-crate-1.3

Conversation

@OliverWoolland

@OliverWoolland OliverWoolland commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Bumping ROCrate version from 1.1 to 1.3 with downstream casualties

@OliverWoolland
OliverWoolland requested a balanced review from Copilot September 21, 2026 13:28
@OliverWoolland OliverWoolland changed the title Ro crate 1.3 RO Crate 1.3 Sep 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Public API documentation is inconsistent with runtime behavior, and one documented output example fails when used as written.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 Medium severity · 4 Low severity

Open (5)
What changed in this PR

Upgrades RO-Crate serialization and examples to specification 1.3 while adding custom JSON-LD context support.

Changes:

  • Updates default context and conformance references to RO-Crate 1.3.
  • Adds ROCrate::addContext.
  • Refreshes integration tests, fixtures, and usage documentation.
File Description
include/​ro-crate.hpp Implements 1.3 serialization and custom contexts.
README.md Documents entity creation, contexts, and output.
tests/​unit.cpp Adds context and entity validation tests.
tests/​integration.cpp Updates and expands 1.3 examples.
tests/​fixtures/​minimal-example-of-ro-crate.json Updates the minimal fixture to 1.3.
tests/​fixtures/​example-with-web-resources.json Updates context metadata to 1.3.
tests/​fixtures/​example-with-file-directory.json Adds the attached-package fixture.
tests/​fixtures/​ro-crate-which-focus-on-multiple-contextual-entities.json Adds a custom-context fixture.
tests/​fixtures/​example-with-file-author-location.json Removes the superseded 1.1 fixture.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/unit.cpp Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread include/ro-crate.hpp Outdated
Comment thread tests/integration.cpp Outdated
OliverWoolland and others added 5 commits September 21, 2026 14:37
Update test case to check for invalid context addition with a URL.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Clarify context link requirements in documentation.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Update output path for RO-Crate metadata file.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated documentation for addContext method to clarify exceptions.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@OliverWoolland
OliverWoolland merged commit 0665cb6 into main Sep 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants