RO Crate 1.3 - #10
Merged
Merged
RO Crate 1.3#10
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Public API documentation is inconsistent with runtime behavior, and one documented output example fails when used as written.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (5)
What changed in this PR
Upgrades RO-Crate serialization and examples to specification 1.3 while adding custom JSON-LD context support.
Changes:
- Updates default context and conformance references to RO-Crate 1.3.
- Adds
ROCrate::addContext. - Refreshes integration tests, fixtures, and usage documentation.
| File | Description |
|---|---|
include/ro-crate.hpp |
Implements 1.3 serialization and custom contexts. |
README.md |
Documents entity creation, contexts, and output. |
tests/unit.cpp |
Adds context and entity validation tests. |
tests/integration.cpp |
Updates and expands 1.3 examples. |
tests/fixtures/minimal-example-of-ro-crate.json |
Updates the minimal fixture to 1.3. |
tests/fixtures/example-with-web-resources.json |
Updates context metadata to 1.3. |
tests/fixtures/example-with-file-directory.json |
Adds the attached-package fixture. |
tests/fixtures/ro-crate-which-focus-on-multiple-contextual-entities.json |
Adds a custom-context fixture. |
tests/fixtures/example-with-file-author-location.json |
Removes the superseded 1.1 fixture. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Update test case to check for invalid context addition with a URL. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Clarify context link requirements in documentation. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Update output path for RO-Crate metadata file. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated documentation for addContext method to clarify exceptions. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Bumping ROCrate version from 1.1 to 1.3 with downstream casualties