SignedXml docs: warn in the verify how-to that parameterless CheckSignature is unsafe for untrusted input - #55645
Merged
Conversation
…nature is unsafe for untrusted input.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens the security guidance in the SignedXml verification how-to by warning that the parameterless SignedXml.CheckSignature() overload is not safe for authenticating untrusted documents because it can select attacker-controlled keys from <KeyInfo>.
Changes:
- Adds an IMPORTANT note advising you to use
SignedXml.CheckSignatureoverloads that take an explicit key or certificate. - Explains why relying on the document-provided
<KeyInfo>does not establish signer trust, and points readers to theSignedXmlremarks for more context.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
gewarren
approved these changes
Aug 25, 2026
…-xml-documents.md Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
gewarren
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal previews
Build report