container: don't copy stdin from a background TTY - #7249
Open
locker95 wants to merge 1 commit into
Open
Conversation
`docker run -i ... &` keeps stdin as the controlling terminal. Reading it from a background process group raises SIGTTIN, which the CLI swallows because it catches every signal for forwarding, so the read retries in a tight loop. Skip the stdin copy when we are not the foreground pgrp, and do not forward TTIN/TTOU to the container. Fixes docker#6005 Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker run -i ... &still has stdin pointed at the terminal. reading that from a background process group raises SIGTTIN, and because we catch every signal (to forward them) the default "stop in the background" never happens — the read just retries and the CLI sits at 100% cpu.if we're not the foreground pgrp, skip the stdin copy. also stop forwarding TTIN/TTOU.
Fixes #6005