Skip to content

Mark nodes completed during rescoring - #730

Merged
MarkWolters merged 2 commits into
mainfrom
compaction_completion_fix
Sep 17, 2026
Merged

MarkWolters merged 2 commits into
mainfrom
compaction_completion_fix

Conversation

@MarkWolters

Copy link
Copy Markdown
Contributor

This PR is a bug fix for the issue reported by the Cassandra team (https://github.com/riptano/cndb/issues/19259) that results in the first 128k vectors copied during compaction being invisible to GraphIndex.View, causing recall scores to plummet after compaction.

When rescore() is called the nodes specified for rescoring are never marked as completed, so they are hidden from the subsequent Views. This PR adds a call to markComplete() for each node added during the call to rescore(). The workaround for this issue implemented by the Cassandra team marks added nodes complete in a batched fashion after rescoring but is otherwise equivalent. It is detailed at datastax/cassandra#2617.

@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Before you submit for review:

  • Does your PR follow guidelines from CONTRIBUTIONS.md?
  • Did you summarize what this PR does clearly and concisely?
  • Did you include performance data for changes which may be performance impacting?
  • Did you include useful docs for any user-facing changes or features?
  • Did you include useful javadocs for developer oriented changes, explaining new concepts or key changes?
  • Did you rebase your branch onto the latest main for regression testing and PR submission?
  • Did you trigger regression testing via Run Bench Main and review results?
  • Did you adhere to the code formatting guidelines (TBD)
  • Did you group your changes for easy review, providing meaningful descriptions for each commit?
  • Did you ensure that all files contain the correct copyright header?
  • Did you add documentation for this feature to the release notes directory?

If you did not complete any of these, then please explain below.

@tlwillke tlwillke left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlwillke tlwillke added the bug Something isn't working label Sep 17, 2026
@MarkWolters
MarkWolters merged commit dc02654 into main Sep 17, 2026
17 checks passed
@MarkWolters
MarkWolters deleted the compaction_completion_fix branch September 17, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants