Mark nodes completed during rescoring - #730
Merged
Merged
Conversation
MarkWolters
requested review from
ashkrisk,
jshook and
tlwillke
as code owners
September 17, 2026 16:46
Contributor
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
tlwillke
reviewed
Sep 17, 2026
jshook
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a bug fix for the issue reported by the Cassandra team (https://github.com/riptano/cndb/issues/19259) that results in the first 128k vectors copied during compaction being invisible to GraphIndex.View, causing recall scores to plummet after compaction.
When rescore() is called the nodes specified for rescoring are never marked as completed, so they are hidden from the subsequent Views. This PR adds a call to
markComplete()for each node added during the call torescore(). The workaround for this issue implemented by the Cassandra team marks added nodes complete in a batched fashion after rescoring but is otherwise equivalent. It is detailed at datastax/cassandra#2617.