Remove unused default-sql versions.tmpl - #6420
Merged
Merged
Conversation
The default-sql bundle template renders no cluster, so its library macros latest_lts_dbr_version and latest_lts_db_connect_version_spec are never referenced. The file contained only these two dead macros; remove it. Split out of the dbt-sql DBR bump (#6418) to keep that PR focused. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: edd9064
Top 3 slowest tests (at least 2 minutes):
|
rugpanov
marked this pull request as ready for review
August 28, 2026 09:23
rclarey
approved these changes
Aug 31, 2026
rugpanov
added a commit
that referenced
this pull request
Sep 2, 2026
…omment - Drop the claims about default-sql's versions.tmpl and the SQL templates pinning an older DBR, both invalidated by #6420 and #6418 - Attribute the 16.4 DB Connect floor to the Python/serverless-env compatibility constraint instead of DBR 15's support status - Remove the comment's absolute "never bump to match the newest serverless environment", which contradicted the hard compatibility constraint - Extend the sync rule and the globs to the hardcoded environment_version and requires-python occurrences outside library/versions.tmpl - Shrink the versions.tmpl comment to the invariant plus a pointer, so the rule has a single home - Reference the rule file by repo-root path and name ./task test-update-templates Co-authored-by: Isaac <no-reply@databricks.com>
hejcman-enverus
pushed a commit
to hejcman-enverus/databricks_cli
that referenced
this pull request
Sep 3, 2026
## Changes Follow-up from databricks#6378: bump the `dbt-sql` bundle template's classic (non-serverless) compute to Databricks Runtime 16.4 LTS. - **dbt-sql**: bump `latest_lts_dbr_version` from `15.4.x-scala2.12` to `16.4.x-scala2.12`. This matches the `default` template (already pinned to 16.4) and aligns the cluster runtime's Python version (3.12) with serverless environment version 5. - **dbt-sql**: remove the unused, TODO-flagged `latest_lts_db_connect_version_spec` macro (flagged for removal in databricks#6378; no template references it). The unrelated dead-code removal in `default-sql/library/versions.tmpl` was split into databricks#6420 (merged); this branch is rebased on top of it. ## Tests - New acceptance variant `acceptance/bundle/templates/dbt-sql-classic` initializes dbt-sql with `serverless: no` and diffs the generated job against the serverless golden, locking in the classic `new_cluster` `spark_version: 16.4.x-scala2.12`. Before this, no acceptance test rendered the classic (non-serverless) path. - Note for future editors: this variant diffs against the sibling `dbt-sql` test's committed golden, so any change to the base `dbt-sql` job template requires regenerating both goldens. - Existing dbt-sql (serverless) template goldens are unchanged; acceptance tests pass. This pull request and its description were written by Isaac. --------- Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Delete
libs/template/templates/default-sql/library/versions.tmpl. Thedefault-sqlbundle template renders no cluster (it targets a SQL warehouse), so its two macros —latest_lts_dbr_versionandlatest_lts_db_connect_version_spec— are never referenced by any template. The file contained only these two dead macros.Split out of #6418 (dbt-sql DBR 16.4 bump) to keep that PR focused on a single change.
Tests
default-sqltemplate acceptance tests pass unchanged after the deletion.This pull request and its description were written by Isaac.