-
Notifications
You must be signed in to change notification settings - Fork 225
Bump dbt-sql to DBR 16.4 LTS for classic compute #6418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| The `dbt-sql` bundle template now uses Databricks Runtime 16.4 LTS (up from 15.4 LTS) for classic (non-serverless) compute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "project_name": "my_dbt_sql", | ||
| "http_path": "/sql/2.0/warehouses/f00dcafe", | ||
| "default_catalog": "main", | ||
| "personal_schemas": "yes", | ||
| "serverless": "no" | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
|
|
||
| >>> [CLI] bundle init dbt-sql --config-file ./input.json --output-dir output | ||
|
|
||
| Welcome to the dbt template for Declarative Automation Bundles! | ||
|
|
||
| A workspace was selected based on your current profile. For information about how to change this, see https://docs.databricks.com/dev-tools/cli/profiles.html. | ||
| workspace_host: [DATABRICKS_URL] | ||
|
|
||
| 📊 Your new project has been created in the 'my_dbt_sql' directory! | ||
| If you already have dbt installed, just type 'cd my_dbt_sql; dbt init' to get started. | ||
| Refer to the README.md file for full "getting started" guide and production setup instructions. | ||
|
|
||
|
|
||
| >>> diff.py [TESTROOT]/bundle/templates/dbt-sql-classic/../dbt-sql/output/my_dbt_sql/resources/my_dbt_sql.job.yml output/my_dbt_sql/resources/my_dbt_sql.job.yml | ||
| --- [TESTROOT]/bundle/templates/dbt-sql-classic/../dbt-sql/output/my_dbt_sql/resources/my_dbt_sql.job.yml | ||
| +++ output/my_dbt_sql/resources/my_dbt_sql.job.yml | ||
| @@ -16,5 +16,4 @@ | ||
| tasks: | ||
| - task_key: dbt | ||
| - environment_key: default | ||
| dbt_task: | ||
| project_directory: ../ | ||
| @@ -27,8 +26,16 @@ | ||
| - 'dbt run --target=${bundle.target} --vars "{ dev_schema: ${workspace.current_user.short_name} }"' | ||
|
|
||
| - environments: | ||
| - - environment_key: default | ||
| - spec: | ||
| - environment_version: "5" | ||
| - dependencies: | ||
| - - dbt-databricks>=1.8.0,<2.0.0 | ||
| + libraries: | ||
| + - pypi: | ||
| + package: dbt-databricks>=1.8.0,<2.0.0 | ||
| + | ||
| + new_cluster: | ||
| + spark_version: 16.4.x-scala2.12 | ||
| + node_type_id: [NODE_TYPE_ID] | ||
| + data_security_mode: DATA_SECURITY_MODE_AUTO | ||
| + num_workers: 0 | ||
| + spark_conf: | ||
| + spark.master: "local[*, 4]" | ||
| + spark.databricks.cluster.profile: singleNode | ||
| + custom_tags: | ||
| + ResourceClass: SingleNode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # With serverless: no, the dbt-sql job runs on a classic new_cluster instead of a | ||
| # serverless environment. Only the job resource differs from the serverless dbt-sql | ||
| # variant, so we diff just that file against the dbt-sql golden. This locks in the | ||
| # new_cluster spark_version (latest_lts_dbr_version). | ||
| trace $CLI bundle init dbt-sql --config-file ./input.json --output-dir output | ||
| trace diff.py $TESTDIR/../dbt-sql/output/my_dbt_sql/resources/my_dbt_sql.job.yml output/my_dbt_sql/resources/my_dbt_sql.job.yml | ||
| rm -fr output | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # This test reads the sibling dbt-sql test's committed golden via $TESTDIR, so it | ||
| # must run in phase 1 (after phase 0 regenerates that golden in update mode). | ||
| Phase = 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.