Skip to content

Fix wording in immutable fields note in managed resources - #1152

Merged
jbw976 merged 2 commits into
crossplane:masterfrom
marcelovilla:patch-1
Sep 16, 2026
Merged

jbw976 merged 2 commits into
crossplane:masterfrom
marcelovilla:patch-1

Conversation

@marcelovilla

Copy link
Copy Markdown
Contributor

I was going over the docs at https://docs.crossplane.io/latest/managed-resources/managed-resources/ and noticed the note Immutable fields section reads weirdly. This is a tiny PR fixing that wording.

@netlify

netlify Bot commented Sep 11, 2026

Copy link
Copy Markdown

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 610b28d
🔍 Latest deploy log https://app.netlify.com/projects/crossplane/deploys/6aa7b6f384bfaa00083267c0
😎 Deploy Preview https://deploy-preview-1152--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 2 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Marcelo Villa <36754005+marcelovilla@users.noreply.github.com>

@jbw976 jbw976 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thank you for finding this! can you also make this same change in content/master? that's the version that will be the next release (e.g. v2.5), so it should be fixed there too.

otherwise, this edit looks good to me! (and it's a refreshingly human feeling contribution 😉)

Signed-off-by: Marcelo Villa <36754005+marcelovilla@users.noreply.github.com>
@marcelovilla

Copy link
Copy Markdown
Contributor Author

Thanks @jbw976, appreciate the quick review! Just pushed the same change to content/master.

@jbw976 jbw976 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for making the update to master too! this looks good to me, just waiting for the queued CI to run before I merge 🙏

@jbw976

jbw976 commented Sep 16, 2026

Copy link
Copy Markdown
Member

30 mins later and CI hasn't started, so I just ran Vale locally on the latest commit in this PR 610b28d and it succeeded ✅

❯ git rev-parse HEAD
610b28d2feaa1b0cc4371f77fa6a0bbf05e6e4ce

❯ vale --config="./utils/vale/.vale.ini" content/master
✔ 0 errors, 0 warnings and 0 suggestions in 54 files.

❯ vale --config="./utils/vale/.vale.ini" content/v2.4/
✔ 0 errors, 0 warnings and 0 suggestions in 54 files.

Let's merge 😂

@jbw976
jbw976 merged commit d1c9eb7 into crossplane:master Sep 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants