Tag Craft Cloud request signatures - #203
Merged
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a0a161-d8cf-758b-bc73-0bae3232314a Co-authored-by: Tim Kelty <tim@pixelandtonic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟡 Changes recommended
Add a unit test confirming verification fails when the signed tag is tampered with.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds the craft-cloud application tag to RFC 9421 request signatures and verifies its serialization.
Changes:
- Adds
tag="craft-cloud"to generated signatures. - Asserts the tag appears in
Signature-Input.
File summaries
| File | Summary |
|---|---|
tests/unit/RequestSignerTest.php |
Verifies the tag is serialized in signed requests. |
src/signing/RequestSigner.php |
Adds the craft-cloud signature tag. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Amp-Thread-ID: https://ampcode.com/threads/T-01a0a161-d8cf-758b-bc73-0bae3232314a Co-authored-by: Tim Kelty <tim@pixelandtonic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tag="craft-cloud"parameter to first-party RFC 9421 request signaturesSignature-InputValidation
php -l src/signing/RequestSigner.phpphp -l tests/unit/RequestSignerTest.phpgit diff --checkThe full repository unit suite was not run because the orb's available PHP 8.2 does not satisfy the lockfile's PHP 8.3 requirement.
Amp thread: https://ampcode.com/threads/T-01a0a161-d8cf-758b-bc73-0bae3232314a