Skip to content

Configurations can pick up failed items that aren't theirs #83

Description

@peterhuffer

Describe the bug
If 2 configurations exist with the same source and destination nodes, it is possible for them to pick up each other's failed items. This is due to the lookup of failed items only taking into account the failure count, source name, and destination name.

See: https://github.com/connexta/replication/blob/master/replication-api-impl/src/main/java/org/codice/ditto/replication/api/impl/SyncHelper.java#L264

Affects version
0.2.2

To Reproduce

  1. Create 2 replications with the same source and destinations, but with different filters.
  2. Replicate on one filter but cause the item to fail.
  3. Run the other configuration. It should attempt to replicate the failed item but fail.

Expected behavior
A configuration should only pick up on its own failed items.

Screenshots
N/A

Desktop (please complete the following information):
N/A

Additional context
N/A

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions