chore: update fullsend shim workflow - #256
fullsend-ai-fullsend[bot] wants to merge 1 commit into
Conversation
Update the shim workflow to match the current template in the .fullsend config repo.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
ReviewFindingsHigh
Next steps:
|
| github.event_name != 'issue_comment' | ||
| || github.event.comment.user.type != 'Bot' | ||
| uses: conforma/.fullsend/.github/workflows/dispatch.yml@e8f0a9f37ce121873e8e320c2758eabee6752df8 # main | ||
| uses: conforma/.fullsend/.github/workflows/dispatch.yml@main |
There was a problem hiding this comment.
[high] supply-chain-pinning
Reusable workflow reference downgraded from a full-length commit SHA (e8f0a9f37ce121873e8e320c2758eabee6752df8) to the mutable branch ref @main. This is a supply-chain regression: any push to conforma/.fullsend's main branch will execute immediately in this repo. The callee runs via workflow_call and inherits the caller's elevated scope (id-token: write for OIDC identity, actions: write) and the parent job is triggered by pull_request_target, so a compromised or attacker-controlled commit to .fullsend@main would gain OIDC-mintable tokens and workflow-dispatch capability against this repository without any review in this repo. Every other uses: reference in .github/workflows/ is SHA-pinned with a version comment, including the direct-precedent reusable-workflow call in auto-merge.yaml. The in-file security comment (lines 7-10) about pull_request_target running the base version of the shim is now partially defeated — the shim itself is safe, but it hands off to @main of an external repo that is mutable.
Suggested fix: Restore a full-length commit SHA pin: uses: conforma/.fullsend/.github/workflows/dispatch.yml@<40-char-sha> # main. Fix the upstream .fullsend template so it distributes a SHA-pinned reference, and rely on Renovate/Dependabot to bump the SHA via reviewable PRs.
This PR updates the fullsend shim workflow to match the current template in the
.fullsendconfig repo.The shim content has drifted from the template — this brings it back in sync.
Getting started
Once this PR is merged, interact with fullsend by commenting one of these slash commands. The supported target (issue and/or pull request) is shown for each:
/fs-triage(issue or PR) — Invoke the triage agent to categorize, label, and assess an issue./fs-code(issue only) — Invoke the code agent to implement a fix for an issue and open a PR./fs-review(PR only) — Invoke the review agent to review a pull request./fs-fix(PR only) — Invoke the fix agent to address review feedback on a pull request./fs-retro(issue or PR) — Invoke the retro agent to analyze completed work and propose improvements./fs-prioritize(issue or PR) — Invoke the prioritize agent to score an issue for project board ranking.