Skip to content

chore: update fullsend shim workflow - #256

Open
fullsend-ai-fullsend[bot] wants to merge 1 commit into
mainfrom
fullsend/onboard
Open

fullsend-ai-fullsend[bot] wants to merge 1 commit into
mainfrom
fullsend/onboard

Conversation

@fullsend-ai-fullsend

Copy link
Copy Markdown
Contributor

This PR updates the fullsend shim workflow to match the current template in the .fullsend config repo.

The shim content has drifted from the template — this brings it back in sync.

Getting started

Once this PR is merged, interact with fullsend by commenting one of these slash commands. The supported target (issue and/or pull request) is shown for each:

  • /fs-triage (issue or PR) — Invoke the triage agent to categorize, label, and assess an issue.
  • /fs-code (issue only) — Invoke the code agent to implement a fix for an issue and open a PR.
  • /fs-review (PR only) — Invoke the review agent to review a pull request.
  • /fs-fix (PR only) — Invoke the fix agent to address review feedback on a pull request.
  • /fs-retro (issue or PR) — Invoke the retro agent to analyze completed work and propose improvements.
  • /fs-prioritize (issue or PR) — Invoke the prioritize agent to score an issue for project board ranking.

Update the shim workflow to match the current template
in the .fullsend config repo.
@fullsend-ai-fullsend
fullsend-ai-fullsend Bot requested a review from a team as a code owner September 16, 2026 14:03
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: fa437d8f-a362-4af6-b275-8aa10b05c11d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

High

  • [supply-chain-pinning] .github/workflows/fullsend.yaml:44 — The reusable workflow reference was downgraded from a full-length commit SHA (e8f0a9f37ce121873e8e320c2758eabee6752df8) to the mutable branch ref @main. This is a supply-chain regression: any push to conforma/.fullsend's main branch will execute immediately in this repo. The callee runs via workflow_call and inherits the caller's elevated scope — id-token: write (OIDC identity for conforma/user-guide) and actions: write — and the parent job is triggered by pull_request_target, so a compromised or attacker-controlled commit to .fullsend@main would gain OIDC-mintable tokens and workflow-dispatch capability against this repository without any review in this repo. Every other uses: reference in .github/workflows/ is SHA-pinned with a version comment, including the direct-precedent reusable-workflow call in auto-merge.yaml (conforma/github-workflows/.../auto-merge.yaml@837d70f4... # main). The in-file security comment (lines 7–10) about pull_request_target running the base version of the shim is now partially defeated — the shim itself is safe, but it hands off to @main of an external repo that is mutable. The PR body's justification ("sync with template") does not address the security regression; the upstream template should itself pin by SHA.
    Remediation: Restore a full-length commit SHA pin: uses: conforma/.fullsend/.github/workflows/dispatch.yml@<40-char-sha> # main. Fix the upstream .fullsend template so it distributes a SHA-pinned reference, and rely on Renovate/Dependabot to bump the SHA via reviewable PRs, rather than tracking a moving branch.

  • [protected-path] .github/workflows/fullsend.yaml — This PR modifies files under a protected path (.github/) but has no linked issue justifying the change. Governance and infrastructure files require explicit authorization; the PR description explains what the change does but does not link an issue authorizing modification of the CI workflow. Human approval is required for protected-path changes.
    Remediation: Link an issue that authorizes this workflow modification, or have a maintainer confirm out-of-band that this protected-path change is intended before merge.


Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

github.event_name != 'issue_comment'
|| github.event.comment.user.type != 'Bot'
uses: conforma/.fullsend/.github/workflows/dispatch.yml@e8f0a9f37ce121873e8e320c2758eabee6752df8 # main
uses: conforma/.fullsend/.github/workflows/dispatch.yml@main

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[high] supply-chain-pinning

Reusable workflow reference downgraded from a full-length commit SHA (e8f0a9f37ce121873e8e320c2758eabee6752df8) to the mutable branch ref @main. This is a supply-chain regression: any push to conforma/.fullsend's main branch will execute immediately in this repo. The callee runs via workflow_call and inherits the caller's elevated scope (id-token: write for OIDC identity, actions: write) and the parent job is triggered by pull_request_target, so a compromised or attacker-controlled commit to .fullsend@main would gain OIDC-mintable tokens and workflow-dispatch capability against this repository without any review in this repo. Every other uses: reference in .github/workflows/ is SHA-pinned with a version comment, including the direct-precedent reusable-workflow call in auto-merge.yaml. The in-file security comment (lines 7-10) about pull_request_target running the base version of the shim is now partially defeated — the shim itself is safe, but it hands off to @main of an external repo that is mutable.

Suggested fix: Restore a full-length commit SHA pin: uses: conforma/.fullsend/.github/workflows/dispatch.yml@<40-char-sha> # main. Fix the upstream .fullsend template so it distributes a SHA-pinned reference, and rely on Renovate/Dependabot to bump the SHA via reviewable PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants