Skip to content

chore: update fullsend shim workflow - #570

Open
fullsend-ai-fullsend[bot] wants to merge 1 commit into
mainfrom
fullsend/onboard
Open

fullsend-ai-fullsend[bot] wants to merge 1 commit into
mainfrom
fullsend/onboard

Conversation

@fullsend-ai-fullsend

Copy link
Copy Markdown
Contributor

This PR updates the fullsend shim workflow to match the current template in the .fullsend config repo.

The shim content has drifted from the template — this brings it back in sync.

Getting started

Once this PR is merged, interact with fullsend by commenting one of these slash commands. The supported target (issue and/or pull request) is shown for each:

  • /fs-triage (issue or PR) — Invoke the triage agent to categorize, label, and assess an issue.
  • /fs-code (issue only) — Invoke the code agent to implement a fix for an issue and open a PR.
  • /fs-review (PR only) — Invoke the review agent to review a pull request.
  • /fs-fix (PR only) — Invoke the fix agent to address review feedback on a pull request.
  • /fs-retro (issue or PR) — Invoke the retro agent to analyze completed work and propose improvements.
  • /fs-prioritize (issue or PR) — Invoke the prioritize agent to score an issue for project board ranking.

Update the shim workflow to match the current template
in the .fullsend config repo.
@fullsend-ai-fullsend
fullsend-ai-fullsend Bot requested a review from a team as a code owner September 16, 2026 14:03
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 225119e2-d46f-49bc-93a7-49960dcab8cf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Preview is available at https://f20630e0.enterprise-contract.pages.dev

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Sep 16, 2026
@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

Bot-authored XS shim workflow update (1 file, 2 lines) with no security-sensitive paths and no dependency changes, but CI_WORKFLOW_CHANGED and a protected-path hit elevate Tier 1 above 1, yielding a moderate composite of 1.55.

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

High

  • [protected-path] .github/workflows/fullsend.yaml:44 — This PR modifies a governance/infrastructure file under a protected path (.github/). No linked issue authorizes the change, so per policy this must be flagged for explicit human approval before merge.

    The substantive change also carries a defense-in-depth concern that human reviewers should confirm intentionally: the uses: reference for the called reusable workflow conforma/.fullsend/.github/workflows/dispatch.yml is being switched from a 40-char commit-SHA pin (@e8f0a9f37ce121873e8e320c2758eabee6752df8 # main) to a mutable branch reference (@main). The caller runs under pull_request_target with elevated permissions (actions: write, id-token: write) and issues a repo-scoped OIDC token to the reusable workflow. Unpinning means any subsequent commit to .fullsend/main (including a force-push, credential compromise, or malicious merge) would execute with those permissions on the next event, with no opportunity for this repo to audit the change. Mitigating context: .fullsend is same-org (not third-party), and the upstream template in conforma/.fullsend/templates/shim-workflow-call.yaml itself uses @main — so this PR really is a shim ↔ template resync, and the choice to track @main may be intentional org policy. Please confirm that org policy accepts @main for same-org reusable workflows and that branch-protection on .fullsend/main provides the intended compensating control.

    Remediation: Either (a) approve explicitly, having confirmed the org policy and branch-protection posture on conforma/.fullsend's main; or (b) re-pin to a full-length commit SHA with a # main trailing comment and let the existing digest-bump automation keep it fresh, restoring the prior defense-in-depth.


Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

github.event_name != 'issue_comment'
|| github.event.comment.user.type != 'Bot'
uses: conforma/.fullsend/.github/workflows/dispatch.yml@e8f0a9f37ce121873e8e320c2758eabee6752df8 # main
uses: conforma/.fullsend/.github/workflows/dispatch.yml@main

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[high] protected-path

PR modifies a governance/infrastructure file under a protected path (.github/). No linked issue explicitly authorizes changes to protected paths, so human approval is required. Additionally, the specific change swaps a 40-char commit-SHA pin (@e8f0a9f37ce121873e8e320c2758eabee6752df8 # main) for a mutable branch reference (@main) on a reusable workflow called under pull_request_target with actions: write + id-token: write. This reduces supply-chain defense-in-depth (subsequent commits to .fullsend/main execute immediately with those permissions and a repo-scoped OIDC token, with no per-consumer audit). Mitigating context: .fullsend is same-org and its upstream template itself uses @main, so this really is a shim resync — but confirm org policy on same-org reusable workflows and the branch-protection posture on .fullsend/main before approving.

Suggested fix: Confirm explicit human approval given org policy and .fullsend/main branch-protection; OR re-pin to a full-length commit SHA with a # main trailing comment and let the existing digest-bump automation keep it up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk/moderate PR risk: moderate size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants