-
Notifications
You must be signed in to change notification settings - Fork 61
Update docker.io/library/golang Docker tag to v1.26.8 (main) #3366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ | |
|
|
||
| ## Build | ||
|
|
||
| FROM docker.io/library/golang:1.26.7@sha256:e30143be198ab04cf7ba25fba83ab3a692ca584c994aad0bf131fa0eb32dd8c1 AS build | ||
| FROM docker.io/library/golang:1.26.8@sha256:3c3e25a4da13fd0478eed2df1eb35a0e667094a7124d3993a6a1d30f71c17e79 AS build | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] protected-path PR modifies Dockerfile, which is in REVIEW_PROTECTED_PATHS. The change is a mechanical Renovate patch bump of the golang build-stage base image from 1.26.7 to 1.26.8 with the sha256 digest also updated; the PR body explains the change and renovate.json authorizes this class of automated dependency update. Human approval is always required for protected-path changes regardless of context. Suggested fix: Verify the new digest sha256:3c3e25a4da13fd0478eed2df1eb35a0e667094a7124d3993a6a1d30f71c17e79 corresponds to the official docker.io/library/golang:1.26.8 image, then have a human reviewer approve before merge. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] protected-path This PR modifies Dockerfile, which is listed in the repository protected paths. The change is a Renovate-managed mechanical patch-version bump of the golang build-stage base image (1.26.7 -> 1.26.8) with a corresponding sha256 digest update; Renovate is configured via renovate.json (extending github>conforma/.github//config/renovate/renovate.json), so the change type is implicitly authorized. Human approval is nevertheless always required for protected-path changes, regardless of context. Suggested fix: A human reviewer must confirm the new digest sha256:3c3e25a4da13fd0478eed2df1eb35a0e667094a7124d3993a6a1d30f71c17e79 matches the upstream docker.io/library/golang:1.26.8 published tag before merging. |
||
|
|
||
| ARG TARGETOS | ||
| ARG TARGETARCH | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[high] protected-path
This PR modifies Dockerfile, which is on the repository's protected-paths list. Protected-path changes require human approval. The PR has no linked issue and the body (standard Renovate boilerplate) does not explicitly justify a change to governance/infrastructure files, so it falls into the 'insufficient context' bucket per the review policy.
Suggested fix: Have a human maintainer review and approve. Optionally link to (or add) a repository policy that explicitly authorizes Renovate-generated Docker base-image bumps under Dockerfile so future PRs of this shape can be downgraded.